Beanstalk Longshot test farm
Menu

#994 perf(vk): the game's per-frame render targets are reused instead of made and destroyed twice a frame

by GummiNaomi closed Open on Forgejo

Commit

Head
a2cdf4e
Base
main a0be15b
Run
2
Approval
approved GummiNaomi, · reviewed

Plan (gpt-6.1-terra)

Linux and AMD: compare market render-target defaults and old settings

In plain words

On Linux and AMD PCs, the plan teleports a fresh child save to the market, moves and turns the camera, then measures for 100 seconds with default pool settings and again with the old-behavior switches. The requested nighttime town save is unavailable, so the plan cannot guarantee night or reproduce the walk into the market; the roughly 25-minute run measures 1% low frame time, hitches and VRAM and captures screenshots. Crashes, substantial frame-time regressions, device-loss logs or screenshot differences beyond tolerance fail the plan. The plan cannot automatically compare the two switch configurations against each other or detect flicker between screenshots. Neither requested target is online now, so both will wait for a matching PC. No tester online now matches linux, amd: those targets wait for one.

Asked for

linux, any GPU: Castle Town's market at night (a save in town, night), walk into the market and turn the camera for a few minutes with the FPS counter on; then the same with RX_VK_TARGET_POOL_MB=256 RX_VK_DEAD_EVERY=10 RX_VK_DEAD_MIN_UNUSED=3 (the old behaviour). Expect fewer dips and slow frames with the defaults and no flicker. Please post both runs' 1 % low or slow-frame counts and whether anything flickered. --- and another request --- amd, Windows or Linux: Castle Town's market at night (a save in town, night), walk into the market and turn the camera for a few minutes with the FPS counter on; then the same with RX_VK_TARGET_POOL_MB=256 RX_VK_DEAD_EVERY=10 RX_VK_DEAD_MIN_UNUSED=3 (the old behaviour). Expect fewer dips and slow frames with the defaults and no flicker. Please post both runs' 1 % low or slow-frame counts and whether anything flickered.

Raw plan 185 lines Download plan.json

  "pass" 
    "crash" false
    "screenshot" 
      "max_diff" 0.05
    
    "frametime_p99_ms" 
      "max_delta_pct" 15
    
    "log_forbidden_hits" 
      "max" 0
    
    "frametime_1pct_low_ms" 
      "max_delta_pct" 15
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
    
      "kind" "vram"
    
    
      "kind" "log_match"
      "expected" 
      "forbidden" 
        "vk: device lost"
      
    
  
  "matrix" 
  "schema" 3
  "target" 
    
      "name" "linux"
      "tags" 
        "linux"
      
      "min_reports" 1
    
    
      "name" "amd"
      "tags" 
        "amd"
      
      "min_reports" 1
    
  
  "summary" "Linux and AMD: compare market render-target defaults and old settings"
  "baseline" 
    "ref" "main"
  
  "scenario" 
    
      "env" 
      "name" "market-default"
      "runs" 1
      "step" 
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "repeat"
          "step" 
            
              "x" 0
              "y" 1
              "do" "stick"
              "stick" "L"
              "frames" 180
            
            
              "x" 1
              "y" 0
              "do" "stick"
              "stick" "R"
              "frames" 90
            
          
          "count" 4
        
        
          "do" "shot"
          "name" "market-first"
          "upload" false
          "compare" "baseline"
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 10
          "duration_s" 100
        
        
          "do" "shot"
          "name" "market-last"
          "upload" false
          "compare" "baseline"
        
      
      "start" "new"
      "matrix" true
      "settings" 
        "fps_counter" 1
        "frame_rate_cap" 6
      
    
    
      "env" 
        "RX_VK_DEAD_EVERY" "10"
        "RX_VK_TARGET_POOL_MB" "256"
        "RX_VK_DEAD_MIN_UNUSED" "3"
      
      "name" "market-old-settings"
      "runs" 1
      "step" 
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "repeat"
          "step" 
            
              "x" 0
              "y" 1
              "do" "stick"
              "stick" "L"
              "frames" 180
            
            
              "x" 1
              "y" 0
              "do" "stick"
              "stick" "R"
              "frames" 90
            
          
          "count" 4
        
        
          "do" "shot"
          "name" "market-first"
          "upload" false
          "compare" "baseline"
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 10
          "duration_s" 100
        
        
          "do" "shot"
          "name" "market-last"
          "upload" false
          "compare" "baseline"
        
      
      "start" "new"
      "matrix" true
      "settings" 
        "fps_counter" 1
        "frame_rate_cap" 6
      
    
  

Targets

TargetTierReportsStatus
linuxreviewed GummiNaomi none yet 0/1 pass, 0 running, 0 queued
amdreviewed GummiNaomi none yet 0/1 pass, 0 running, 0 queued

Reports

No reports yet. Each tester posts one when its job ends.

Jobs

JobCommitTargetStateTesterAttemptsNote
jb_fd18159c64a5723fa2cdf4eamd cancelled—0 the PR was closed
jb_c08ed055d23d29f0a2cdf4elinux cancelled—0 the PR was closed