#772 WIP: fix(vk): an event signal's add writes the value the stream gives the event

Commit

Head: 2c5a62e
Base: main aa95d35
Run: 2
Approval: approved dyst, 7 h ago · reviewed

Plan (gpt-6.1-terra)

Kokiri Forest replay comparison: defaults and parallel recording

In plain words

Compare the pull request with main in Kokiri Forest for two minutes per run, first with defaults and then with RX_VK_PARALLEL=4 to exercise parallel replay. The plan measures frame times, compares pictures, and checks for replay-order wait warnings. Crashes, warnings, substantial frame-time regressions, or picture differences fail the plan; this game run does not directly prove ADD-signal correctness.

Asked for

once more, please: the same plan (Kokiri Forest two minutes, defaults and RX_VK_PARALLEL=4, this PR against main).

Raw plan 118 lines Download plan.json

{
  "pass": {
    "crash": false,
    "screenshot": {
      "max_diff": 0.05
    },
    "frametime_p99_ms": {
      "max_delta_pct": 15
    },
    "log_forbidden_hits": {
      "max": 0
    }
  },
  "probe": [
    {
      "kind": "crash"
    },
    {
      "kind": "frametime"
    },
    {
      "kind": "log_match",
      "expected": [],
      "forbidden": [
        "vk: a wait not met in replay order"
      ]
    }
  ],
  "matrix": {},
  "schema": 3,
  "target": [
    {
      "name": "linux",
      "tags": [
        "linux"
      ],
      "min_reports": 1
    }
  ],
  "summary": "Kokiri Forest replay comparison: defaults and parallel recording",
  "baseline": {
    "ref": "main"
  },
  "scenario": [
    {
      "env": {},
      "name": "kokiri-default",
      "runs": 1,
      "step": [
        {
          "do": "wait",
          "map": "KokiriForest_Child",
          "event": "map",
          "timeout_s": 120
        },
        {
          "x": 0,
          "y": 1,
          "do": "stick",
          "stick": "L",
          "frames": 120
        },
        {
          "do": "shot",
          "name": "forest",
          "upload": false,
          "compare": "baseline"
        },
        {
          "do": "measure",
          "name": "forest",
          "warmup_s": 5,
          "duration_s": 120
        }
      ],
      "start": "new",
      "matrix": true,
      "settings": {}
    },
    {
      "env": {
        "RX_VK_PARALLEL": "4"
      },
      "name": "kokiri-parallel",
      "runs": 1,
      "step": [
        {
          "do": "wait",
          "map": "KokiriForest_Child",
          "event": "map",
          "timeout_s": 120
        },
        {
          "x": 0,
          "y": 1,
          "do": "stick",
          "stick": "L",
          "frames": 120
        },
        {
          "do": "shot",
          "name": "forest",
          "upload": false,
          "compare": "baseline"
        },
        {
          "do": "measure",
          "name": "forest",
          "warmup_s": 5,
          "duration_s": 120
        }
      ],
      "start": "new",
      "matrix": true,
      "settings": {}
    }
  ]
}

Targets

Target	Tier	Reports	Status
linux	reviewed dyst	1	0/1 pass, 1 error

Reports

Report	Commit	Target	Tester	Result	When
rp_a4aeeeca85a2bbee	2c5a62e run 2	linux	jabbaxipil/Blaine	error	3 h ago
rp_20b7db7482e51065	2c5a62e	linux	jabbaxipil/Blaine	error	7 h ago

Jobs

Job	Commit	Target	State	Tester	Attempts	Note
`jb_7dfffa9c7aed4b53`	2c5a62e	linux	done report	jabbaxipil/Blaine	1
`jb_b1f5464b96e0ba0f`	2c5a62e	linux	done report	jabbaxipil/Blaine	1