Beanstalk Longshot test farm
Menu

#2232 WIP: perf(vk): Threaded rendering's Auto runs the recorder thread from 4 cores, not 6

by klimovich008 open Open on Forgejo

Commit

Head
f554451
Base
main a2dc538
Approval
approved klimovich008, · reviewed

Plan (gpt-6.1-terra)

Compare Auto threading on four-core discrete-GPU PCs in Hyrule Field and the Market

⚠️ Note: The model groups permit either operating system and GPU maker, but do not guarantee coverage of both; none of the listed CPUs appears in the current online inventory.

⚠️ Note: Threaded rendering uses its default Auto value because it is not an exposed plan setting; the main-side Auto line is available in its log but cannot be separately enforced by a PR-only expected-log rule.

⚠️ Note: The farm cannot select a power-saving plan or target an unspecified four-core laptop.

In plain words

Compare main and the PR on discrete-GPU PCs with the requested four-core CPU models, using Threaded rendering Auto with no switches. Three starts per build measure 30 seconds each in Hyrule Field and the Market, taking roughly 32 minutes per tester; no matching CPU is currently online, so the targets will wait. The PR fails on a crash, a missing expected Auto-mode log line, a 5% FPS loss, a 10% p99 frame-time increase, or a substantial screenshot difference. Whole-run hitch counts and maximum frame times are reported without limits. No tester online now matches dgpu+cpu-3300x_i3-10100_i3-12100_i3-13100_i7-6700_i7-6700k_i7-7700_i7-7700k, dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200: those targets wait for one.

Asked for

main against this PR, both on Threaded rendering Auto, no switch on either side: this PR changes what Auto picks on CPUs with 4 or 5 physical cores and a discrete GPU, so only those PCs can show a difference. Targets: PCs with a discrete GPU (the dgpu tag) and a CPU of 4 physical cores or fewer, by model. With SMT (4C/8T): i7-6700K, i7-7700K, i7-6700, i7-7700, i3-10100, i3-12100, i3-13100, Ryzen 3 3300X. Without SMT (4C/4T): i5-6500, i5-6600K, i5-7400, i5-7500, i5-7600K, Ryzen 3 1200, 1300X, 3100. An NVIDIA and an AMD card if the testers have them, Windows and Linux both. 2- and 3-core PCs log the same "Auto: off" line on both builds, and 6-core and bigger PCs run both threads on both builds: those compare the same mode. No Steam Deck target here (Auto is off there on both builds: no mirrors). Settings, both sides: frame_rate_cap = 6 (Uncapped), vsync = 2 (Off), frame_generation = 0. Headless is fine (the change is in the replay, not the present path); no window scenario. Scenario: Hyrule Field (HyruleField_Child) measured 30 s, then the Market (Market_Child) measured 30 s in the same start; 3 game starts a side (2 at least). Rules, PR vs main: fps_mean.min_delta_pct = 5 and frametime_p99_ms.max_delta_pct = 10 on each segment, crash = false. Hitch counts (run_hitch_count, run_frametime_max_ms) report-only. Log check on the PR side: "vk: Threaded rendering: Auto: on, the render thread and the recorder thread (4 cores" expected, and main's "Auto: the render thread only (4 cores" shown, so we can see the tester's PC was in the tier that changes.

Raw plan 139 lines Download plan.json

  "pass" 
    "crash" false
    "fps_mean" 
      "min_delta_pct" 5
    
    "screenshot" 
      "max_diff" 0.1
    
    "frametime_p99_ms" 
      "max_delta_pct" 10
    
    "log_expected_missing" 
      "max" 0
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
    
      "kind" "draws"
    
    
      "kind" "log_match"
      "expected" 
        "vk: Threaded rendering: Auto: on, the render thread and the recorder thread \\(4 cores"
      
      "forbidden" 
    
  
  "matrix" 
  "schema" 4
  "target" 
    
      "cpu" 
        "3300x"
        "i3 10100"
        "i3 12100"
        "i3 13100"
        "i7 6700"
        "i7 6700k"
        "i7 7700"
        "i7 7700k"
      
      "name" "dgpu+cpu-3300x_i3-10100_i3-12100_i3-13100_i7-6700_i7-6700k_i7-7700_i7-7700k"
      "tags" 
        "dgpu"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "cpu" 
        "1300x"
        "3100"
        "i5 6500"
        "i5 6600k"
        "i5 7400"
        "i5 7500"
        "i5 7600k"
        "ryzen 3 1200"
      
      "name" "dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200"
      "tags" 
        "dgpu"
      
      "max_reports" 2
      "min_reports" 1
    
  
  "summary" "Compare Auto threading on four-core discrete-GPU PCs in Hyrule Field and the Market"
  "baseline" 
    "ref" "main"
  
  "scenario" 
    
      "env" 
      "name" "field-market"
      "runs" 3
      "step" 
        
          "do" "teleport"
          "to" "HyruleField_Child"
        
        
          "do" "wait"
          "map" "HyruleField_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "field"
          "warmup_s" 10
          "duration_s" 30
        
        
          "do" "shot"
          "name" "field"
          "upload" false
          "compare" "baseline"
        
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 10
          "duration_s" 30
        
        
          "do" "shot"
          "name" "market"
          "upload" false
          "compare" "baseline"
        
      
      "start" "save:castle-gate"
      "matrix" true
      "settings" 
        "vsync" 2
        "frame_rate_cap" 6
        "frame_generation" 0
      
    
  

Targets

TargetTierReportsStatus
dgpu+cpu-3300x_i3-10100_i3-12100_i3-13100_i7-6700_i7-6700k_i7-7700_i7-7700k CPU "3300x" or "i3 10100" or "i3 12100" or "i3 13100" or "i7 6700" or "i7 6700k" or "i7 7700" or "i7 7700k"reviewed klimovich008 none yet 0/1 pass, 0 running, 2 queued
dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200 CPU "1300x" or "3100" or "i5 6500" or "i5 6600k" or "i5 7400" or "i5 7500" or "i5 7600k" or "ryzen 3 1200"reviewed klimovich008 none yet 0/1 pass, 0 running, 2 queued

Reports

No reports yet. Each tester posts one when its job ends.

Jobs

No tester has a PC for `dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200` (none seen in 14 days): it waits until one signs in.

JobCommitTargetStateTesterStartedAttemptsEstimateNote
jb_45c595e0a8e74453f554451dgpu+cpu-3300x_i3-10100_i3-12100_i3-13100_i7-6700_i7-6700k_i7-7700_i7-7700k queued—0 No tester online can take it now.No tester online matches `dgpu+cpu-3300x_i3-10100_i3-12100_i3-13100_i7-6700_i7-6700k_i7-7700_i7-7700k`.
jb_bb844baee9e4842ff554451dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200 queued—0 No tester has a PC for `dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200` (none seen in 14 days): it waits until one signs in.No tester online matches `dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200`.
jb_57ccdc6c6b1633edf554451dgpu+cpu-3300x_i3-10100_i3-12100_i3-13100_i7-6700_i7-6700k_i7-7700_i7-7700k queued—0 No tester online can take it now.No tester online matches `dgpu+cpu-3300x_i3-10100_i3-12100_i3-13100_i7-6700_i7-6700k_i7-7700_i7-7700k`.
jb_46c048780e729459f554451dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200 queued—0 No tester has a PC for `dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200` (none seen in 14 days): it waits until one signs in.No tester online matches `dgpu+cpu-1300x_3100_i5-6500_i5-6600k_i5-7400_i5-7500_i5-7600k_ryzen-3-1200`.