Beanstalk Longshot test farm
Menu

#2124 fix(input): XInput is read on a thread of its own, so players with no controller no longer hitch every second

by HumanBean closed Open on Forgejo

Commit

Head
a34b94a
Base
main 971f77f
Approval
can't be tested as asked: see the farm's comment

Plan (gpt-6.1-terra)

Not planned yet.

⚠️ Note: The frame-time probe reports summary metrics, not the once-per-second spike pattern, so it cannot establish that the periodic hitch is gone.

In plain words

The alternative plan measures 60 seconds of stationary frame times in Kokiri Forest on Windows, comparing three starts each of main and the PR. It fails on a crash or a 15% regression in 99th-percentile frame time. The unattended farm cannot ensure that controllers are disconnected or perform the requested Xbox pad hot-plug test.

Asked for

windows: with no controller plugged in (keyboard and mouse only), stand still in Kokiri Forest for 60 s and record frame times on main and on this PR. On main I expect a frame-time spike once a second; here it should be gone. Then, if the PC has an Xbox pad, set HOS_NO_SDL=1, plug the pad in mid-game, and check its buttons and both sticks work as they do on main.

can't test this as asked: The requested comparison requires a verified controller-free Windows PC and physical Xbox pad hot-plugging, neither of which the unattended farm can arrange; HOS_NO_SDL is also prohibited. The alternative can compare stationary frame times on Windows but cannot verify the device setup or physical input.

Targets

The plan has no targets yet.

Reports

No reports yet. Each tester posts one when its job ends.

Jobs

No jobs. Jobs are made once the plan is approved.