Beanstalk Longshot test farm
Menu

#2100 WIP: fix(linux): RX_VK_NO_DMABUF leaves the guest window anonymous memory, so its pools can be host-pointer imports

by dyst open Open on Forgejo

Summary

The change failed on Linux RADV due to a picture difference on the RX 7900 XTX with the switch unset; the RX 890M report could not be judged. The screenshot difference was 0.0564, above the 0.05 limit. On the RX 7900 XTX, switch-unset Market frame time p99 rose from 36.85 to 43.56 ms (+18.2%), but this comparison was inconclusive because there were too few usable starts. Both PCs timed out in both switch scenarios, leaving all required frame-time comparisons inconclusive.

Written by AI (gpt-6.1-terra) from this commit's results, once every target finished.

Commit

Head
b04ee7b
Base
main d76d202
Run
2
Approval
approved dyst, · reviewed

Plan (gpt-6.1-terra)

Compare RADV guest-memory imports with RX_VK_NO_DMABUF on and unset

⚠️ Note: The farm cannot enforce that /dev/udmabuf is usable; without it, the requested main-side failure and default dma-buf path may not be exercised.

⚠️ Note: The first 30-second measurement starts after teleporting to Hyrule Field, not immediately after the Kokiri save loads. Log matches are reported but cannot be made conditional on the switch in these separate scenarios.

In plain words

On Linux RADV, compare main and the PR with RX_VK_NO_DMABUF=1 and with the switch unset. Each run loads the Kokiri save, measures the first 30 seconds in Hyrule Field, stands there for another 30 seconds, then visits the Market. The plan reports frame times and import-related log matches, and fails on crashes, substantial frame-time regressions or picture differences. It takes approximately 45 minutes per tester.

Asked for

(again for b04ee7b, rebased past #2098's build fix) only RADV on Linux, with /dev/udmabuf usable: this changes only what RX_VK_NO_DMABUF=1 does at start-up. Run main and this PR each with RX_VK_NO_DMABUF=1 set, and each with nothing set. Load a save in Hyrule Field, stand a minute, then go to the Market. With the switch, main should log pools 'not imported' and run at a few fps for a while after the load; this PR should log 'mem: RX_VK_NO_DMABUF: the guest window is anonymous memory, for host-pointer imports', import its pools and play as it does without the switch. With nothing set the two builds should match (the window a memfd's, guest memory as dma-bufs). Report the import lines ('not imported', 'imports: ... live'), the frame times in the first 30 s after the load, and the 'vk: guest memory as dma-bufs' line of each run. --- and another request --- test it anyway

Raw plan 167 lines Download plan.json

  "pass" 
    "crash" false
    "screenshot" 
      "max_diff" 0.05
    
    "frametime_p99_ms" 
      "max_delta_pct" 30
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
    
      "kind" "log_match"
      "missing" "unjudged"
      "expected" 
        "mem: RX_VK_NO_DMABUF: the guest window is anonymous memory, for host-pointer imports"
        "not imported"
        "imports: .* live"
        "vk: guest memory as dma-bufs"
      
      "forbidden" 
    
  
  "matrix" 
  "schema" 10
  "target" 
    
      "name" "linux+radv"
      "tags" 
        "linux"
        "radv"
      
      "max_reports" 2
      "min_reports" 1
    
  
  "summary" "Compare RADV guest-memory imports with RX_VK_NO_DMABUF on and unset"
  "baseline" 
    "ref" "main"
  
  "scenario" 
    
      "env" 
        "RX_VK_NO_DMABUF" "1"
      
      "name" "switch-on"
      "runs" 2
      "step" 
        
          "do" "teleport"
          "to" "HyruleField_Child"
        
        
          "do" "wait"
          "map" "HyruleField_Child"
          "event" "map"
          "timeout_s" 120
        
        
          "do" "measure"
          "name" "field-first-30"
          "warmup_s" 0
          "duration_s" 30
        
        
          "do" "wait_s"
          "seconds" 30
        
        
          "do" "shot"
          "name" "field"
          "upload" false
          "compare" "baseline"
        
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 120
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 5
          "duration_s" 10
        
        
          "do" "shot"
          "name" "market"
          "upload" false
          "compare" "baseline"
        
      
      "start" "save:kokiri-start"
      "matrix" true
      "settings" 
    
    
      "env" 
      "name" "switch-unset"
      "runs" 2
      "step" 
        
          "do" "teleport"
          "to" "HyruleField_Child"
        
        
          "do" "wait"
          "map" "HyruleField_Child"
          "event" "map"
          "timeout_s" 120
        
        
          "do" "measure"
          "name" "field-first-30"
          "warmup_s" 0
          "duration_s" 30
        
        
          "do" "wait_s"
          "seconds" 30
        
        
          "do" "shot"
          "name" "field"
          "upload" false
          "compare" "baseline"
        
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 120
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 5
          "duration_s" 10
        
        
          "do" "shot"
          "name" "market"
          "upload" false
          "compare" "baseline"
        
      
      "start" "save:kokiri-start"
      "matrix" true
      "settings" 
    
  

Targets

TargetTierReportsStatus
linux+radvreviewed dyst 1 2 1/1 fail

Reports

ReportCommitTargetTesterResultWhen
rp_07cd4bf981e1bff1b04ee7b run 2linux+radv McButt531/agent-b08055error outlier
rp_1a84cc8026b7ddfcb04ee7b run 2linux+radv jabbaxipil/RX7900XTX-Linuxfail outlier

Jobs

JobCommitTargetStateTesterStartedAttemptsEstimateNote
jb_f50b62fc15f9a78f logb04ee7blinux+radv done reportMcButt531/agent-b080552 lease expired, tried again: the tester missed its heartbeats
jb_93b15c8274f85c65 logb04ee7blinux+radv done reportjabbaxipil/RX7900XTX-Linux3 prefetch: Access to the path '<data>/python.unpack/python/bin/2to3' is denied.