#1866 perf(vk): the recorder takes a whole part and submits it, so the render thread never waits at a part's end
Commit
Plan (gpt-6.1-terra)
Compare recorder submission in three areas across requested platforms
In plain words
Against main, three starts per side will visit Kokiri Forest, Hyrule Field and Market with V-Sync off and the frame-rate cap uncapped; threaded rendering remains at its default Auto. Each area gets a 20-second standing measurement and a camera-turn exercise with comparison pictures; the farm cannot measure while issuing the turn input. The plan measures FPS, p99 frame time and stutters, and fails on crashes, area-arrival timeouts, substantial performance regressions or picture differences. Each target takes roughly 35 minutes; the Windows and Linux Intel targets will wait for matching testers to come online. No tester online now matches windows+intel, linux+intel: those targets wait for one.
Asked for
Please test this PR against main on every platform: windows+amd, windows+nvidia, windows+intel, linux+amd, linux+nvidia, linux+intel, the steamdeck, amd+igpu. Settings vsync=2 (Off) and frame_rate_cap=6 (Uncapped), Threaded rendering Auto. From the `kokiri-start` save: Kokiri Forest, Hyrule Field and Castle Town Market, in each 20 s standing then 15 s turning the camera, three game starts a side; make sure each side has reached the area before measuring it. Measure fps, p99 frame time, stutters, crashes and hangs (a hang is the main risk: this changes which thread submits the GPU's work), and compare pictures with main. This only acts where the recorder thread runs (6+ cores); on the Steam Deck and 4-core PCs it should be even.
Raw plan Download plan.json
{
"pass": {
"crash": false,
"fps_mean": {
"min_delta_pct": 5
},
"screenshot": {
"max_diff": 0.05
},
"stutter_count": {
"max_delta_pct": 20
},
"frametime_p99_ms": {
"max_delta_pct": 10
},
"log_forbidden_hits": {
"max": 0
}
},
"probe": [
{
"kind": "crash"
},
{
"kind": "frametime"
},
{
"kind": "draws"
},
{
"kind": "log_match",
"expected": [],
"forbidden": [
"vk: device lost"
]
}
],
"matrix": {},
"schema": 3,
"target": [
{
"name": "windows+amd",
"tags": [
"windows",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+nvidia",
"tags": [
"windows",
"nvidia"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+intel",
"tags": [
"windows",
"intel"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+amd",
"tags": [
"linux",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+nvidia",
"tags": [
"linux",
"nvidia"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+intel",
"tags": [
"linux",
"intel"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "steamdeck",
"tags": [
"steamdeck"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "amd+igpu",
"tags": [
"amd",
"igpu"
],
"max_reports": 2,
"min_reports": 1
}
],
"summary": "Compare recorder submission in three areas across requested platforms",
"baseline": {
"ref": "main"
},
"scenario": [
{
"env": {},
"name": "three-areas",
"runs": 3,
"step": [
{
"do": "teleport",
"to": "KokiriForest_Child"
},
{
"do": "wait",
"map": "KokiriForest_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "forest-standing",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "forest-standing",
"upload": false,
"compare": "baseline"
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 300
},
{
"do": "shot",
"name": "forest-turned",
"upload": false,
"compare": "baseline"
},
{
"do": "teleport",
"to": "HyruleField_Child"
},
{
"do": "wait",
"map": "HyruleField_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "field-standing",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "field-standing",
"upload": false,
"compare": "baseline"
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 300
},
{
"do": "shot",
"name": "field-turned",
"upload": false,
"compare": "baseline"
},
{
"do": "teleport",
"to": "Market_Child"
},
{
"do": "wait",
"map": "Market_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "market-standing",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "market-standing",
"upload": false,
"compare": "baseline"
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 300
},
{
"do": "shot",
"name": "market-turned",
"upload": false,
"compare": "baseline"
}
],
"start": "save:kokiri-start",
"matrix": true,
"settings": {
"vsync": 2,
"frame_rate_cap": 6
}
}
]
}
Targets
| Target | Tier | Reports | Status |
|---|---|---|---|
| windows+amd | reviewed HumanBean | 1 | 1/1 fail |
| windows+nvidia | reviewed HumanBean | 1 | 0/1 pass, 1 error |
| windows+intel | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| linux+amd | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| linux+nvidia | reviewed HumanBean | 1 2 | 1/1 fail |
| linux+intel | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| steamdeck | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| amd+igpu | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
Reports
| Report | Commit | Target | Tester | Result | When |
|---|---|---|---|---|---|
| rp_40dabb02ecc42fd9 | f08644e run 2 | linux+nvidia | Hidden tester | error | |
| rp_58e348c5ebac64ff | f08644e run 2 | linux+nvidia | Nerdtality/agent-0452e3 | fail outlier | |
| rp_c89210d0846b746f | f08644e run 2 | windows+amd | Razytos/agent-d8f902 | fail outlier | |
| rp_9993b02c2c799c3b | f08644e run 2 | windows+nvidia | CubanLegend/agent-341924 | error | |
| rp_b5cf890ddf8fdfea | f08644e | steamdeck | Flashman4/agent-0e17b1 | fail | |
| rp_f47d73c8897e8c71 | f08644e | amd+igpu | Flashman4/agent-0e17b1 | fail | |
| rp_a469be1b399ffdbd | f08644e | linux+nvidia | Nerdtality/agent-0452e3 | fail outlier | |
| rp_69e22fd96ba9a4f5 | f08644e | linux+amd | icyblue8/agent-368f00 | fail | |
| rp_d549463ccce0ea2f | f08644e | linux+nvidia | jabbaxipil/Blaine | fail outlier | |
| rp_28cd9c2a5d5a15aa | f08644e | windows+amd | Hidden tester | fail outlier | |
| rp_24abd5b090f1f8b3 | f08644e | windows+nvidia | Samsheperd/agent-a9f512 | fail | |
| rp_18b65d3e2212c214 | f08644e | windows+amd | Razytos/agent-d8f902 | fail outlier | |
| rp_ff5f883c9bb9d420 | f08644e | windows+nvidia | CubanLegend/agent-341924 | error |
Jobs
| Job | Commit | Target | State | Tester | Started | Attempts | Estimate | Note |
|---|---|---|---|---|---|---|---|---|
jb_e19ead19ca880bd4 log | f08644e | linux+intel | cancelled | — | 0 | the PR was closed | ||
jb_059387f2c9d57b40 log | f08644e | linux+amd | cancelled | — | 3 | the PR was closed | ||
jb_e5ed3bbf69e5dfda log | f08644e | windows+amd | cancelled run | Hidden tester | 1 | the PR was closed | ||
jb_e9cd4f911cbdb97a log | f08644e | windows+intel | cancelled | — | 0 | the PR was closed | ||
jb_8b085a4f7524c2b0 log | f08644e | windows+amd | done run | Razytos/agent-d8f902 | 1 | |||
jb_36ad5aa96783e3dc log | f08644e | windows+nvidia | done build-base | CubanLegend/agent-341924 | 1 | |||
jb_8c7ec8028531a691 log | f08644e | linux+nvidia | done run | Nerdtality/agent-0452e3 | 1 | |||
jb_13270176ad890acb log | f08644e | linux+nvidia | done run | Hidden tester | 1 | |||
jb_09a77b3aeefabf34 log | f08644e | linux+amd | cancelled | — | 3 | the PR was closed | ||
jb_3647920838babe3d log | f08644e | windows+intel | cancelled | — | 0 | the PR was closed | ||
jb_fdf6fff16ddab8f6 log | f08644e | amd+igpu | cancelled | — | 1 | the PR was closed | ||
jb_f2ee8a9fe860e845 log | f08644e | linux+intel | cancelled | — | 0 | the PR was closed | ||
jb_2571797ddcaf0ae0 log | f08644e | steamdeck | cancelled | — | 0 | the PR was closed | ||
jb_c6aa7dfd411f0fc8 log | f08644e | steamdeck | cancelled | — | 0 | the PR was closed | ||
jb_ff2aea9ecfa04a2f log | f08644e | windows+nvidia | cancelled run | thebasedpisces/agent-8d2999 | 1 | the PR was closed | ||
jb_c65f173a02bd2dfe log | f08644e | amd+igpu | cancelled | — | 0 | the PR was closed | ||
jb_6c6ef3d176cfe738 log | f08644e | linux+amd off target | cancelled run | Hidden tester | 1 | report: the farm refused the report: the coordinator answered HTTP 400 (BadRequest): {"error":"report.rules[8].status must be one of pass, fail, unsupported, skipped, mismatch"} | ||
jb_014b294408e11d0c log | f08644e | amd+igpu | cancelled | — | 0 | re-planned by HumanBean | ||
jb_59058eddd19e2a77 log | f08644e | windows+intel | cancelled | — | 0 | re-planned by HumanBean | ||
jb_b9c09ca42dba084a log | f08644e | linux+intel | cancelled | — | 0 | re-planned by HumanBean | ||
jb_cd4badfecf8790c0 log | f08644e | steamdeck | cancelled | — | 0 | re-planned by HumanBean | ||
jb_8d64ca719d102eca log | f08644e | windows+nvidia | done build-base | CubanLegend/agent-341924 | 1 | |||
jb_5ad747b00df33c6a log | f08644e | linux+nvidia | done run | Nerdtality/agent-0452e3 | 2 | report: the farm refused the report: the coordinator answered HTTP 400 (BadRequest): {"error":"report.rules[8].status must be one of pass, fail, unsupported, skipped, mismatch"} | ||
jb_d7f757f4ab0fcfc7 log | f08644e | windows+intel | cancelled | — | 1 | re-planned by HumanBean | ||
jb_0f9640f09742f6ae log | f08644e | linux+amd | done report | icyblue8/agent-368f00 | 1 | |||
jb_5d02fa36adbc1897 log | f08644e | windows+nvidia | done run | Samsheperd/agent-a9f512 | 1 | |||
jb_ed72347a7a5ba3fc log | f08644e | steamdeck | done report | Flashman4/agent-0e17b1 | 2 | stopped by the tester: you stopped testing | ||
jb_a37031b0eae8c83e log | f08644e | linux+nvidia | done run | jabbaxipil/Blaine | 1 | |||
jb_96d2e03480909ed6 log | f08644e | windows+amd | done run | Hidden tester | 1 | |||
jb_51ee259a83a4129a log | f08644e | linux+amd | cancelled prefetch | Flashman4/agent-0e17b1 | 4 | re-planned by HumanBean | ||
jb_377c393f48c2c691 log | f08644e | amd+igpu | done report | Flashman4/agent-0e17b1 | 1 | |||
jb_d83388282c2f5fd2 log | f08644e | windows+amd | done report | Razytos/agent-d8f902 | 1 | |||
jb_b3cc2de5a8f1c764 log | f08644e | linux+intel | cancelled | — | 0 | re-planned by HumanBean |