Beanstalk Longshot test farm
Menu

#1811 perf(vk): the next frame is recorded during OoT's frame limiter's wait and held until its signal (HOS_NVN_FRAME_OVERLAP, off by default)

by GummiNaomi closed Open on Forgejo

Commit

Head
dae496f
Base
main 89c3d21
Approval
approved GummiNaomi, · reviewed

Plan (gpt-6.1-terra)

Compare frame overlap on and off for two minutes in the child Market

In plain words

The plan compares overlap enabled with the same PR build's default at the child Market, standing for two minutes after teleporting from kokiri-start. It measures FPS and frame times and compares sampled images; a crash, lower FPS or a substantial image difference fails. Windows, Linux NVIDIA, Linux AMD, Windows AMD, Windows Intel and Steam Deck targets are included; Windows Intel may wait for a matching tester. The farm cannot select CPUs by core count or enable the requested frame trace, so the 16-core-specific question and trace are not isolated; the guard-mode log test is also not included. No tester online now matches windows+intel: that target waits for one.

Asked for

windows (a 16-core or larger CPU), linux+nvidia, linux+amd, windows+amd, windows+intel and steamdeck: Castle Town's market (child), standing 2 minutes after a teleport from kokiri-start, `RX_VK_FRAME_TRACE=1`, `HOS_NVN_FRAME_OVERLAP=1` against unset. Expecting no crash, no flicker and fps no lower than unset; on the 16-core PC whether `=1` is faster (it was +7.5 % there before main's render-thread rewrite, and within the spread on 4 cores here). On one Windows PC also `HOS_NVN_FRAME_OVERLAP=2` set at the start, expecting the log's guard counts at 0 and every `vk: HOS_NVN_FRAME_OVERLAP (600 presents)` line saying released at the signal, the bound reached 0 times. (The farm's runs on #1846 and #1847 today ended in `error` before building: its checkout of main failed `git rev-parse --verify HEAD^{commit}` in packs.py's cmd_base.)

Raw plan 129 lines Download plan.json

  "pass" 
    "crash" false
    "fps_mean" 
      "min_delta_pct" 0
    
    "screenshot" 
      "max_diff" 0.05
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
    
      "kind" "draws"
    
    
      "at_s" 
        5
        30
        60
        110
      
      "kind" "screenshot"
      "upload" false
      "compare" "baseline"
    
  
  "matrix" 
    "pr_only" 
      "HOS_NVN_FRAME_OVERLAP" 
        "1"
      
    
  
  "schema" 6
  "target" 
    
      "name" "windows"
      "tags" 
        "windows"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+nvidia"
      "tags" 
        "linux"
        "nvidia"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+amd"
      "tags" 
        "linux"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+amd"
      "tags" 
        "windows"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+intel"
      "tags" 
        "windows"
        "intel"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "steamdeck"
      "tags" 
        "steamdeck"
      
      "max_reports" 2
      "min_reports" 1
    
  
  "summary" "Compare frame overlap on and off for two minutes in the child Market"
  "baseline" 
    "ref" "pr"
  
  "scenario" 
    
      "env" 
      "name" "child-market"
      "runs" 1
      "step" 
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 0
          "duration_s" 120
        
      
      "start" "save:kokiri-start"
      "matrix" true
      "settings" 
        "frame_rate_cap" 6
      
    
  

Targets

TargetTierReportsStatus
windowsreviewed GummiNaomi 1 2 0/1 pass, 2 error
linux+nvidiareviewed GummiNaomi 1 2 0/1 pass, 2 error
linux+amdreviewed GummiNaomi 1 2 0/1 pass, 2 error
windows+amdreviewed GummiNaomi 1 2 2/1 fail
windows+intelreviewed GummiNaomi none yet 0/1 pass, 0 running, 0 queued
steamdeckreviewed GummiNaomi 1 0/1 pass, 1 error

Reports

ReportCommitTargetTesterResultWhen
rp_2e92e8d0132d646fdae496flinux+amd McButt531/agent-b08055error
rp_50407ef1e483a118dae496fsteamdeck Flashman4/agent-0e17b1error
rp_4206b88c1f2b0e74dae496fwindows+amd Hidden testerfail outlier
rp_471283aedd20d375dae496fwindows+amd Razytos/agent-d8f902fail outlier
rp_a9e1c5525dcc4c2edae496fwindows Smokedribbs/agent-d43eb8error
rp_94348ce735ccc5fadae496flinux+amd icyblue8/agent-368f00error
rp_b6052e83255a942adae496flinux+nvidia Nerdtality/agent-0452e3error
rp_5f5d60f8bfdee07cdae496fwindows CubanLegend/agent-341924error
rp_9965a50b1a986f9edae496flinux+nvidia Hidden testererror

Jobs

JobCommitTargetStateTesterStartedAttemptsEstimateNote
jb_6e8acb396a9d7093 logdae496fwindows+intel cancelled—0 the PR was closed
jb_832e6c122a360e81 logdae496fwindows+intel cancelled—0 the PR was closed
jb_9a921d0ec9ac9a58 logdae496fsteamdeck cancelled—0 the PR was closed
jb_03b8fefc7a6e55a5 logdae496fwindows done reportCubanLegend/agent-3419241
jb_57c253dd02245659 logdae496flinux+nvidia done build-prHidden tester1
jb_9cbdc551ab053b67 logdae496flinux+amd done build-pricyblue8/agent-368f002 prefetch: Input/output error : '<data>/jobs/jb_9cbdc551ab053b67'
jb_22e205c4a9c6d19b logdae496fsteamdeck done build-prFlashman4/agent-0e17b11
jb_fa26809ba77be16a logdae496fwindows+amd done reportHidden tester1
jb_f48e1d6061af6bf4 logdae496fwindows done runSmokedribbs/agent-d43eb81
jb_0b22e11d0bde3b4a logdae496flinux+nvidia done reportNerdtality/agent-0452e31
jb_fb562d99d386e7d7 logdae496fwindows+amd done reportRazytos/agent-d8f9021
jb_d62bf28fcffb20bd logdae496flinux+amd done build-prMcButt531/agent-b0805513 setup: Your .nup could not be read (reading it stopped, exit 127): nice: ‘<data>/python/bin/python3’: No such file or directory