#1763 perf(vk): the renderer's threads rewritten: one render thread, the presenter on every PC, parts that end at the game's own pass ends
Commit
Plan (gpt-6.1-terra)
Compare recorder defaults and recorder off across three areas on the requested platforms
In plain words
The plan compares main with the PR’s default recorder behavior and with the recorder disabled, because the new head restores that thread on PCs with at least six physical cores. Two starts per side visit Kokiri Forest, Hyrule Field and Market with V-Sync off and the frame rate uncapped, measuring FPS, p99 frame time and stutters and comparing pictures. Camera turns are exercised, but performance is measured immediately after each turn rather than during it. Crashes, significant performance regressions or large picture differences fail the run; each tester’s game runs take roughly 45 minutes. The requested Intel targets have no testers shown online and will wait for matching PCs. No tester online now matches windows+intel, linux+intel: those targets wait for one.
Asked for
(new head 4543d04: the recorder thread is back, from 6 physical cores, without the segment workers. It moves the driver's calls off the render thread, which should recover the Market standing loss on fast GPUs, AMD most.) Please test this PR against main on every platform: windows+amd, windows+nvidia, windows+intel, linux+amd, linux+nvidia, linux+intel, the steamdeck, amd+igpu. Settings vsync=2 (Off) and frame_rate_cap=6 (Uncapped), Threaded rendering Auto. From the `kokiri-start` save: Kokiri Forest, Hyrule Field and Castle Town Market, in each 20 s standing then 15 s turning the camera, two game starts a side; make sure each side has reached the area before measuring it. Measure fps, p99 frame time, stutters and crashes, and compare pictures with main. Matrix, on every platform, two cells: the PR's defaults; and the PR with env `RX_VK_RECORDER=off` (the same build without the recorder thread), each against main.
Raw plan Download plan.json
{
"pass": {
"crash": false,
"fps_mean": {
"min_delta_pct": 10
},
"screenshot": {
"max_diff": 0.1
},
"stutter_count": {
"max_delta_pct": 25
},
"frametime_p99_ms": {
"max_delta_pct": 15
},
"log_forbidden_hits": {
"max": 0
}
},
"probe": [
{
"kind": "crash"
},
{
"kind": "frametime"
},
{
"kind": "draws"
},
{
"kind": "log_match",
"expected": [],
"forbidden": [
"vk: device lost"
]
}
],
"matrix": {
"pr_only": {
"RX_VK_RECORDER": [
"off"
]
}
},
"schema": 3,
"target": [
{
"name": "windows+amd",
"tags": [
"windows",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+nvidia",
"tags": [
"windows",
"nvidia"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+intel",
"tags": [
"windows",
"intel"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+amd",
"tags": [
"linux",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+nvidia",
"tags": [
"linux",
"nvidia"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+intel",
"tags": [
"linux",
"intel"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "steamdeck",
"tags": [
"steamdeck"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "amd+igpu",
"tags": [
"amd",
"igpu"
],
"max_reports": 2,
"min_reports": 1
}
],
"summary": "Compare recorder defaults and recorder off across three areas on the requested platforms",
"baseline": {
"ref": "main"
},
"scenario": [
{
"env": {},
"name": "three-areas",
"runs": 2,
"step": [
{
"do": "teleport",
"to": "KokiriForest_Child"
},
{
"do": "wait",
"map": "KokiriForest_Child",
"event": "map",
"timeout_s": 90
},
{
"do": "measure",
"name": "forest-standing",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "forest",
"upload": false,
"compare": "baseline"
},
{
"x": 1.0,
"y": 0.0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"x": 1.0,
"y": 0.0,
"do": "stick",
"stick": "R",
"frames": 300
},
{
"do": "measure",
"name": "forest-after-turn",
"warmup_s": 0,
"duration_s": 15
},
{
"do": "teleport",
"to": "HyruleField_Child"
},
{
"do": "wait",
"map": "HyruleField_Child",
"event": "map",
"timeout_s": 90
},
{
"do": "measure",
"name": "field-standing",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "field",
"upload": false,
"compare": "baseline"
},
{
"x": 1.0,
"y": 0.0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"x": 1.0,
"y": 0.0,
"do": "stick",
"stick": "R",
"frames": 300
},
{
"do": "measure",
"name": "field-after-turn",
"warmup_s": 0,
"duration_s": 15
},
{
"do": "teleport",
"to": "Market_Child"
},
{
"do": "wait",
"map": "Market_Child",
"event": "map",
"timeout_s": 90
},
{
"do": "measure",
"name": "market-standing",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "market",
"upload": false,
"compare": "baseline"
},
{
"x": 1.0,
"y": 0.0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"x": 1.0,
"y": 0.0,
"do": "stick",
"stick": "R",
"frames": 300
},
{
"do": "measure",
"name": "market-after-turn",
"warmup_s": 0,
"duration_s": 15
}
],
"start": "save:kokiri-start",
"matrix": true,
"settings": {
"vsync": 2,
"frame_rate_cap": 6
}
}
]
}
Targets
| Target | Tier | Reports | Status |
|---|---|---|---|
| windows+amd | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| windows+nvidia | reviewed HumanBean | 1 | 0/1 pass, 1 error |
| windows+intel | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| linux+amd | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| linux+nvidia | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| linux+intel | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| steamdeck | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| amd+igpu | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
Reports
Jobs
| Job | Commit | Target | State | Tester | Started | Attempts | Estimate | Note |
|---|---|---|---|---|---|---|---|---|
jb_561ccdc6d49246ef log | 4543d04 | linux+intel | cancelled | — | 0 | the PR was closed | ||
jb_7c77a7db762d9c50 log | 4543d04 | windows+nvidia | cancelled | — | 0 | the PR was closed | ||
jb_5b1ac725b43aef2a log | 4543d04 | linux+intel | cancelled | — | 0 | the PR was closed | ||
jb_87ebd25068fe036d log | 4543d04 | linux+nvidia | cancelled | — | 0 | the PR was closed | ||
jb_4e069f451f275e19 log | 4543d04 | linux+amd | cancelled | — | 0 | the PR was closed | ||
jb_6653987ed400aecd log | 4543d04 | windows+amd | cancelled | — | 0 | the PR was closed | ||
jb_cd757b792003c228 log | 4543d04 | windows+intel | cancelled | — | 0 | the PR was closed | ||
jb_3c956145807be5c8 log | 4543d04 | linux+nvidia | cancelled | — | 0 | the PR was closed | ||
jb_22f826e61f5427d3 log | 4543d04 | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_470aaa619d4b3547 log | 4543d04 | windows+amd | cancelled | — | 0 | the PR was closed | ||
jb_1cf4b279ebb86212 log | 4543d04 | amd+igpu | cancelled run | icyblue8/agent-d6ebcb | 1 | the PR was closed | ||
jb_316be6670b154098 log | 4543d04 | windows+intel | cancelled | — | 0 | the PR was closed | ||
jb_9426e95f81dba61d log | 4543d04 | amd+igpu | cancelled | — | 0 | the PR was closed | ||
jb_73edcbcedde41bc5 log | 4543d04 | steamdeck | cancelled | — | 0 | the PR was closed | ||
jb_a1aeb54cd0eae959 log | 4543d04 | steamdeck | cancelled | — | 0 | the PR was closed | ||
jb_1bdd5570b26e89de log | 4543d04 | linux+amd | cancelled run | Alberania/agent-af6cf3 | 1 | the PR was closed | ||
jb_ce80c9264c4dc93f log | 8ba0d02 | linux+intel off target | cancelled build-pr | Nerdtality/agent-0452e3 | 1 | superseded by a new push | ||
jb_23d0707c7f7531ef log | 8ba0d02 | steamdeck | cancelled build-base | AONE/agent-431b42 | 1 | superseded by a new push | ||
jb_cbf6361aa8fdd7a2 log | 8ba0d02 | windows+amd | cancelled build-base | Razytos/agent-d8f902 | 1 | superseded by a new push | ||
jb_03eb4141ec5caa16 log | 8ba0d02 | amd+igpu | done report | Flashman4/agent-0e17b1 | 1 | |||
jb_4c7bd74c4e2dc92c log | 8ba0d02 | windows+amd | done run | Hidden tester | 1 | |||
jb_b9ee4271f1619e0c log | 8ba0d02 | linux+nvidia | done run | jabbaxipil/Blaine | 1 | |||
jb_a271e70e63bb8e83 log | 8ba0d02 | amd+igpu | done report | icyblue8/agent-d6ebcb | 1 | |||
jb_9b096a814c01899b log | 8ba0d02 | linux+nvidia | done fetch | Nerdtality/agent-a30c86 | 1 | |||
jb_28e9c5cd7fd599f3 log | 8ba0d02 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_f76a41c240bcf9ad log | 8ba0d02 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_a75404c0eb424034 log | 8ba0d02 | steamdeck | cancelled run | Flashman4/agent-0e17b1 | 1 | superseded by a new push | ||
jb_d5a108e462224720 log | 8ba0d02 | linux+amd | done report | Alberania/agent-af6cf3 | 1 | |||
jb_1694aff63cb66514 log | 8ba0d02 | linux+amd | cancelled | — | 0 | superseded by a new push | ||
jb_e770ff11e5d34549 log | 8ba0d02 | windows+nvidia | done run | Samsheperd/agent-a9f512 | 1 | |||
jb_c5630a229a5bc042 log | 8ba0d02 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_784720655e2b4d3d log | 8ba0d02 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_4ae2468dd0ace519 log | 8ba0d02 | windows+nvidia | done report | Hidden tester | 1 | |||
jb_92762d6288e7dc15 log | 69263e4 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_9f91aa47c03bd573 log | 69263e4 | amd+igpu | cancelled | — | 0 | superseded by a new push | ||
jb_1e43d3fa26046cb0 log | 69263e4 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_fbae6bdd7e5c0a09 log | 69263e4 | windows+nvidia | done report | Smokedribbs/agent-d43eb8 | 1 | |||
jb_8f766d57fc4ae011 log | 69263e4 | linux+amd | done report | icyblue8/agent-368f00 | 1 | |||
jb_1fc5ec28103e73c8 log | 69263e4 | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_8c58ca9ed233d3eb log | 69263e4 | linux+amd | done report | Alberania/agent-af6cf3 | 1 | |||
jb_6543bf898d8bb665 log | 69263e4 | windows+amd | done run | Hidden tester | 1 | |||
jb_b700ae1fa635ebf8 log | 69263e4 | linux+nvidia | cancelled prefetch | Nerdtality/agent-a30c86 | 1 | superseded by a new push | ||
jb_0a7a77c6a4959e7a log | 69263e4 | amd+igpu | cancelled build-base | AONE/agent-431b42 | 1 | superseded by a new push | ||
jb_098285fe6d65fcd8 log | 69263e4 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_504bc36f19a71a29 log | 69263e4 | linux+nvidia | done run | Hidden tester | 1 | |||
jb_870ceb872cf4991f log | 69263e4 | windows+amd | cancelled | — | 0 | superseded by a new push | ||
jb_70380dbf91f5cbf9 log | 69263e4 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_d89f64887454777d log | 69263e4 | steamdeck | cancelled | — | 0 | superseded by a new push | ||
jb_335501c7f8c5f35b log | 69263e4 | steamdeck | cancelled | — | 0 | superseded by a new push | ||
jb_a49b3600441495d2 log | 21b606e | windows+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt | done report | Hidden tester | 1 | |||
jb_cd2a97fbd25fb28e log | 21b606e | linux+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt | done report | Alberania/agent-af6cf3 | 1 | |||
jb_fd9d86b4990f8840 log | 21b606e | windows+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt | cancelled | — | 0 | superseded by a new push | ||
jb_37c5b6b62fb0afb3 log | 21b606e | linux+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt | cancelled | — | 0 | superseded by a new push | ||
jb_e5c82b6dd727685d log | 21b606e | linux+amd | done report | SweatyEggs69/agent-cf0be7 | 1 | |||
jb_921143c6b63e99d6 log | 21b606e | windows+intel | cancelled | — | 0 | re-planned by HumanBean | ||
jb_a1ffb54fc0a4cc42 log | 21b606e | windows+intel | cancelled | — | 0 | re-planned by HumanBean | ||
jb_a0a3cd17ec346b7b log | 21b606e | linux+nvidia | cancelled | — | 0 | re-planned by HumanBean | ||
jb_b2c359a644e50e6b log | 21b606e | linux+intel | cancelled | — | 0 | re-planned by HumanBean | ||
jb_ed4215c118e26fba log | 21b606e | linux+intel | cancelled | — | 0 | re-planned by HumanBean | ||
jb_6d31aa3647ada28e log | 21b606e | steamdeck | cancelled | — | 0 | re-planned by HumanBean | ||
jb_c02deaab0ffaa464 log | 21b606e | amd+igpu | done report | Flashman4/agent-0e17b1 | 1 | |||
jb_fca19761a0839dc5 log | 21b606e | linux+nvidia | done run | Hidden tester | 1 | |||
jb_beb80e80b7523c8a log | 21b606e | windows+nvidia | done report | Flashman4/agent-de36c5 | 1 | |||
jb_f0dccc83d8127bb6 log | 21b606e | amd+igpu | done report | Hidden tester | 1 | |||
jb_a140e207eff818e1 log | 21b606e | windows+amd | cancelled build-base | pickaxe/agent-607ffe | 1 | re-planned by HumanBean | ||
jb_21799cd2e6ae07ff log | 21b606e | windows+nvidia | done build-base | CubanLegend/agent-341924 | 1 | |||
jb_064bdfb498aaabb9 log | 21b606e | linux+amd | cancelled build-pr | icyblue8/agent-368f00 | 1 | re-planned by HumanBean | ||
jb_082b57e5ea843017 log | 21b606e | windows+amd | done report | Hidden tester | 1 | |||
jb_db1bb6698bd2870c log | 21b606e | steamdeck | done report | Flashman4/agent-0e17b1 | 1 | |||
jb_3e4ab5747f3c9dbc log | a2cc7b5 | linux+nvidia off target | done report | CubanLegend/agent-341924 | 1 | |||
jb_10da33d70de7ce3b log | a2cc7b5 | steamdeck | cancelled | — | 1 | superseded by a new push | ||
jb_c79f2be2a0a7276e log | a2cc7b5 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_12304896c8800630 log | a2cc7b5 | amd+igpu | done report | Hidden tester | 1 | |||
jb_646703eeb1d10ea8 log | a2cc7b5 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_6188ca5698afc253 log | a2cc7b5 | linux+amd | done report | Hidden tester | 1 | |||
jb_8d4d05a37e14ee46 log | a2cc7b5 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_b913bbee15b04f5d log | a2cc7b5 | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_05f9d41dec02ee58 log | a2cc7b5 | steamdeck | cancelled build-pr | Flashman4/agent-0e17b1 | 1 | superseded by a new push | ||
jb_19e624f98a68503c log | a2cc7b5 | linux+amd | done report | Alberania/agent-af6cf3 | 1 | |||
jb_e2333b5113a2b248 log | a2cc7b5 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_133ec59b0af4f6b7 log | a2cc7b5 | amd+igpu | done report | Hidden tester | 1 | |||
jb_d6b16583e7e4b5cf log | a2cc7b5 | linux+nvidia | cancelled | — | 0 | superseded by a new push | ||
jb_975e30a449ffa1d5 log | a2cc7b5 | windows+amd | cancelled build-base | pickaxe/agent-607ffe | 6 | superseded by a new push | ||
jb_b6c896b6e3f7c5e0 log | a2cc7b5 | windows+nvidia | done report | Flashman4/agent-de36c5 | 2 | passing, tried again: fetch: git clone failed: Cloning into '<data>\longshot'... fatal: unable to access 'https://git.magicbean.dev/MagicBeanDev/Longshot.git/': schannel: next InitializeSecurityContext failed: CRYPT_E_REVOCATION_OFFLINE (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline. (tried 4 times) | ||
jb_583f3b18ab86c2b1 log | a2cc7b5 | windows+amd | done report | Razytos/agent-d8f902 | 1 | |||
jb_9682de3a3718cf27 log | a2cc7b5 | linux+nvidia | done run | Hidden tester | 1 | |||
jb_690d0f4d23e8cd3c log | 85c0d23 | linux+nvidia off target | cancelled prefetch | akkusativ/agent-0a71fc | 1 | build-base: the agent failed: WinError: SetNamedSecurityInfoW (the low integrity label on <data>\base-home): error 5 (0x5, Zugriff verweigert) | ||
jb_665b0c1a893ead12 log | 85c0d23 | steamdeck | cancelled | — | 0 | superseded by a new push | ||
jb_6cb208b9ea461eff log | 85c0d23 | amd+igpu | cancelled build-base | Hidden tester | 2 | superseded by a new push | ||
jb_8ad2b3dd7c173687 log | 85c0d23 | windows+nvidia | done report | thebasedpisces/agent-8d2999 | 1 | |||
jb_3acb23c479d03b61 log | 85c0d23 | linux+nvidia | cancelled run | Hidden tester | 1 | superseded by a new push | ||
jb_7c7f1d525c7b1d91 log | 85c0d23 | amd+igpu | cancelled prefetch | Hidden tester | 2 | superseded by a new push | ||
jb_7019ff3f2161146d log | 85c0d23 | steamdeck | cancelled | — | 0 | superseded by a new push | ||
jb_06fb66a875c17c97 log | 85c0d23 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_4b1e6b378e12a0b4 log | 85c0d23 | linux+nvidia | cancelled | — | 0 | superseded by a new push | ||
jb_ff1b760303c16cc8 log | 85c0d23 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_de09b3bf561afc15 log | 85c0d23 | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_a6bdce24b83cdfde log | 85c0d23 | linux+amd | done report | SweatyEggs69/agent-cf0be7 | 1 | |||
jb_97af62b69671e371 log | 85c0d23 | windows+amd | cancelled | — | 3 | superseded by a new push | ||
jb_7f74a0edd9854520 log | 85c0d23 | linux+amd | done report | Alberania/agent-af6cf3 | 1 |