Beanstalk Longshot test farm
Menu

#1763 perf(vk): the renderer's threads rewritten: one render thread, the presenter on every PC, parts that end at the game's own pass ends

by HumanBean closed Open on Forgejo

Commit

Head
4543d04
Base
main 08994a9
Approval
approved HumanBean, · reviewed

Plan (gpt-6.1-terra)

Compare recorder defaults and recorder off across three areas on the requested platforms

In plain words

The plan compares main with the PR’s default recorder behavior and with the recorder disabled, because the new head restores that thread on PCs with at least six physical cores. Two starts per side visit Kokiri Forest, Hyrule Field and Market with V-Sync off and the frame rate uncapped, measuring FPS, p99 frame time and stutters and comparing pictures. Camera turns are exercised, but performance is measured immediately after each turn rather than during it. Crashes, significant performance regressions or large picture differences fail the run; each tester’s game runs take roughly 45 minutes. The requested Intel targets have no testers shown online and will wait for matching PCs. No tester online now matches windows+intel, linux+intel: those targets wait for one.

Asked for

(new head 4543d04: the recorder thread is back, from 6 physical cores, without the segment workers. It moves the driver's calls off the render thread, which should recover the Market standing loss on fast GPUs, AMD most.) Please test this PR against main on every platform: windows+amd, windows+nvidia, windows+intel, linux+amd, linux+nvidia, linux+intel, the steamdeck, amd+igpu. Settings vsync=2 (Off) and frame_rate_cap=6 (Uncapped), Threaded rendering Auto. From the `kokiri-start` save: Kokiri Forest, Hyrule Field and Castle Town Market, in each 20 s standing then 15 s turning the camera, two game starts a side; make sure each side has reached the area before measuring it. Measure fps, p99 frame time, stutters and crashes, and compare pictures with main. Matrix, on every platform, two cells: the PR's defaults; and the PR with env `RX_VK_RECORDER=off` (the same build without the recorder thread), each against main.

Raw plan 264 lines Download plan.json

  "pass" 
    "crash" false
    "fps_mean" 
      "min_delta_pct" 10
    
    "screenshot" 
      "max_diff" 0.1
    
    "stutter_count" 
      "max_delta_pct" 25
    
    "frametime_p99_ms" 
      "max_delta_pct" 15
    
    "log_forbidden_hits" 
      "max" 0
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
    
      "kind" "draws"
    
    
      "kind" "log_match"
      "expected" 
      "forbidden" 
        "vk: device lost"
      
    
  
  "matrix" 
    "pr_only" 
      "RX_VK_RECORDER" 
        "off"
      
    
  
  "schema" 3
  "target" 
    
      "name" "windows+amd"
      "tags" 
        "windows"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+nvidia"
      "tags" 
        "windows"
        "nvidia"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+intel"
      "tags" 
        "windows"
        "intel"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+amd"
      "tags" 
        "linux"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+nvidia"
      "tags" 
        "linux"
        "nvidia"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+intel"
      "tags" 
        "linux"
        "intel"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "steamdeck"
      "tags" 
        "steamdeck"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "amd+igpu"
      "tags" 
        "amd"
        "igpu"
      
      "max_reports" 2
      "min_reports" 1
    
  
  "summary" "Compare recorder defaults and recorder off across three areas on the requested platforms"
  "baseline" 
    "ref" "main"
  
  "scenario" 
    
      "env" 
      "name" "three-areas"
      "runs" 2
      "step" 
        
          "do" "teleport"
          "to" "KokiriForest_Child"
        
        
          "do" "wait"
          "map" "KokiriForest_Child"
          "event" "map"
          "timeout_s" 90
        
        
          "do" "measure"
          "name" "forest-standing"
          "warmup_s" 5
          "duration_s" 20
        
        
          "do" "shot"
          "name" "forest"
          "upload" false
          "compare" "baseline"
        
        
          "x" 1.0
          "y" 0.0
          "do" "stick"
          "stick" "R"
          "frames" 600
        
        
          "x" 1.0
          "y" 0.0
          "do" "stick"
          "stick" "R"
          "frames" 300
        
        
          "do" "measure"
          "name" "forest-after-turn"
          "warmup_s" 0
          "duration_s" 15
        
        
          "do" "teleport"
          "to" "HyruleField_Child"
        
        
          "do" "wait"
          "map" "HyruleField_Child"
          "event" "map"
          "timeout_s" 90
        
        
          "do" "measure"
          "name" "field-standing"
          "warmup_s" 5
          "duration_s" 20
        
        
          "do" "shot"
          "name" "field"
          "upload" false
          "compare" "baseline"
        
        
          "x" 1.0
          "y" 0.0
          "do" "stick"
          "stick" "R"
          "frames" 600
        
        
          "x" 1.0
          "y" 0.0
          "do" "stick"
          "stick" "R"
          "frames" 300
        
        
          "do" "measure"
          "name" "field-after-turn"
          "warmup_s" 0
          "duration_s" 15
        
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 90
        
        
          "do" "measure"
          "name" "market-standing"
          "warmup_s" 5
          "duration_s" 20
        
        
          "do" "shot"
          "name" "market"
          "upload" false
          "compare" "baseline"
        
        
          "x" 1.0
          "y" 0.0
          "do" "stick"
          "stick" "R"
          "frames" 600
        
        
          "x" 1.0
          "y" 0.0
          "do" "stick"
          "stick" "R"
          "frames" 300
        
        
          "do" "measure"
          "name" "market-after-turn"
          "warmup_s" 0
          "duration_s" 15
        
      
      "start" "save:kokiri-start"
      "matrix" true
      "settings" 
        "vsync" 2
        "frame_rate_cap" 6
      
    
  

Targets

TargetTierReportsStatus
windows+amdreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
windows+nvidiareviewed HumanBean 1 0/1 pass, 1 error
windows+intelreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
linux+amdreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
linux+nvidiareviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
linux+intelreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
steamdeckreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
amd+igpureviewed HumanBean none yet 0/1 pass, 0 running, 0 queued

Reports

ReportCommitTargetTesterResultWhen
rp_6918b8605a0e4fb34543d04windows+nvidia Hidden testererror
rp_32212f8a9379f5438ba0d02amd+igpu icyblue8/agent-d6ebcbpass outlier
rp_2f62a6866fd6272c8ba0d02linux+nvidia jabbaxipil/Blainepass
rp_1e2a6d44b508a3668ba0d02windows+amd Hidden testerfail
rp_7376d0cf82cdecf48ba0d02amd+igpu Flashman4/agent-0e17b1fail outlier
rp_21c02fb7ff77d2888ba0d02windows+nvidia Samsheperd/agent-a9f512fail
rp_b47b80f27c0c9ecd8ba0d02linux+amd Alberania/agent-af6cf3fail
rp_f544ba03d5b9a8438ba0d02windows+nvidia Hidden testererror
rp_a166fe985da3a48a8ba0d02linux+nvidia Nerdtality/agent-a30c86error
rp_d6671f9cc193c33169263e4windows+nvidia Smokedribbs/agent-d43eb8fail
rp_0d4d810e316340cf69263e4linux+nvidia Hidden testererror
rp_4cd053887e72956469263e4windows+amd Hidden testerfail
rp_ecb9e9784622e84069263e4linux+amd icyblue8/agent-368f00fail outlier
rp_d2f84dc3f782ca1b69263e4linux+amd Alberania/agent-af6cf3fail outlier
rp_7f84777e6f00d96769263e4windows+nvidia Hidden testererror
rp_6a40d25c92db342321b606e run 2windows+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt Hidden testerfail
rp_ee51f502e4beaa1a21b606e run 2linux+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt Alberania/agent-af6cf3fail
rp_9bec439f939ab51921b606eamd+igpu Flashman4/agent-0e17b1fail outlier
rp_18ae2dddc053534c21b606ewindows+nvidia Flashman4/agent-de36c5fail
rp_1785830c5a9dffd921b606elinux+nvidia Hidden testererror
rp_b43bad86ac2dac8b21b606esteamdeck Flashman4/agent-0e17b1fail
rp_dea048ff0a3001bf21b606eamd+igpu Hidden testerfail outlier
rp_0b2c30e6fd8302f021b606ewindows+amd Hidden testerfail
rp_d6bffe70774fb1e021b606elinux+amd SweatyEggs69/agent-cf0be7fail
rp_ca2a478b5d338a8d21b606ewindows+nvidia CubanLegend/agent-341924error
rp_e46ae7e4ee04c30aa2cc7b5linux+nvidia CubanLegend/agent-341924fail off target
rp_ebcdda49abed53ada2cc7b5windows+nvidia Flashman4/agent-de36c5fail
rp_4be1ca7c7b82e2fea2cc7b5windows+amd Razytos/agent-d8f902fail
rp_43e0263c89565cf2a2cc7b5amd+igpu Hidden testerfail
rp_f364084243440858a2cc7b5linux+nvidia Hidden testererror
rp_8a65ac1d92af5f80a2cc7b5linux+amd Hidden testerfail outlier
rp_dc42e91c4f46f3eaa2cc7b5amd+igpu Hidden testererror
rp_6ed6fe8ef91ac4f5a2cc7b5linux+amd Alberania/agent-af6cf3fail outlier
rp_2aeded2141050710a2cc7b5windows+nvidia Hidden testererror
rp_b051cb093387ac2785c0d23windows+nvidia thebasedpisces/agent-8d2999fail
rp_eedfff236d4fddc385c0d23linux+amd SweatyEggs69/agent-cf0be7fail outlier
rp_62a0802c7ceda67585c0d23linux+amd Alberania/agent-af6cf3fail outlier
rp_0954dc7f3eee131785c0d23windows+nvidia Hidden testererror
rp_7d8dbc2686d159db9259257windows+nvidia Hidden testererror

Jobs

JobCommitTargetStateTesterStartedAttemptsEstimateNote
jb_561ccdc6d49246ef log4543d04linux+intel cancelled—0 the PR was closed
jb_7c77a7db762d9c50 log4543d04windows+nvidia cancelled—0 the PR was closed
jb_5b1ac725b43aef2a log4543d04linux+intel cancelled—0 the PR was closed
jb_87ebd25068fe036d log4543d04linux+nvidia cancelled—0 the PR was closed
jb_4e069f451f275e19 log4543d04linux+amd cancelled—0 the PR was closed
jb_6653987ed400aecd log4543d04windows+amd cancelled—0 the PR was closed
jb_cd757b792003c228 log4543d04windows+intel cancelled—0 the PR was closed
jb_3c956145807be5c8 log4543d04linux+nvidia cancelled—0 the PR was closed
jb_22f826e61f5427d3 log4543d04windows+nvidia done build-baseHidden tester1
jb_470aaa619d4b3547 log4543d04windows+amd cancelled—0 the PR was closed
jb_1cf4b279ebb86212 log4543d04amd+igpu cancelled runicyblue8/agent-d6ebcb1 the PR was closed
jb_316be6670b154098 log4543d04windows+intel cancelled—0 the PR was closed
jb_9426e95f81dba61d log4543d04amd+igpu cancelled—0 the PR was closed
jb_73edcbcedde41bc5 log4543d04steamdeck cancelled—0 the PR was closed
jb_a1aeb54cd0eae959 log4543d04steamdeck cancelled—0 the PR was closed
jb_1bdd5570b26e89de log4543d04linux+amd cancelled runAlberania/agent-af6cf31 the PR was closed
jb_ce80c9264c4dc93f log8ba0d02linux+intel off target cancelled build-prNerdtality/agent-0452e31 superseded by a new push
jb_23d0707c7f7531ef log8ba0d02steamdeck cancelled build-baseAONE/agent-431b421 superseded by a new push
jb_cbf6361aa8fdd7a2 log8ba0d02windows+amd cancelled build-baseRazytos/agent-d8f9021 superseded by a new push
jb_03eb4141ec5caa16 log8ba0d02amd+igpu done reportFlashman4/agent-0e17b11
jb_4c7bd74c4e2dc92c log8ba0d02windows+amd done runHidden tester1
jb_b9ee4271f1619e0c log8ba0d02linux+nvidia done runjabbaxipil/Blaine1
jb_a271e70e63bb8e83 log8ba0d02amd+igpu done reporticyblue8/agent-d6ebcb1
jb_9b096a814c01899b log8ba0d02linux+nvidia done fetchNerdtality/agent-a30c861
jb_28e9c5cd7fd599f3 log8ba0d02linux+intel cancelled—0 superseded by a new push
jb_f76a41c240bcf9ad log8ba0d02linux+intel cancelled—0 superseded by a new push
jb_a75404c0eb424034 log8ba0d02steamdeck cancelled runFlashman4/agent-0e17b11 superseded by a new push
jb_d5a108e462224720 log8ba0d02linux+amd done reportAlberania/agent-af6cf31
jb_1694aff63cb66514 log8ba0d02linux+amd cancelled—0 superseded by a new push
jb_e770ff11e5d34549 log8ba0d02windows+nvidia done runSamsheperd/agent-a9f5121
jb_c5630a229a5bc042 log8ba0d02windows+intel cancelled—0 superseded by a new push
jb_784720655e2b4d3d log8ba0d02windows+intel cancelled—0 superseded by a new push
jb_4ae2468dd0ace519 log8ba0d02windows+nvidia done reportHidden tester1
jb_92762d6288e7dc15 log69263e4windows+intel cancelled—0 superseded by a new push
jb_9f91aa47c03bd573 log69263e4amd+igpu cancelled—0 superseded by a new push
jb_1e43d3fa26046cb0 log69263e4windows+intel cancelled—0 superseded by a new push
jb_fbae6bdd7e5c0a09 log69263e4windows+nvidia done reportSmokedribbs/agent-d43eb81
jb_8f766d57fc4ae011 log69263e4linux+amd done reporticyblue8/agent-368f001
jb_1fc5ec28103e73c8 log69263e4windows+nvidia done build-baseHidden tester1
jb_8c58ca9ed233d3eb log69263e4linux+amd done reportAlberania/agent-af6cf31
jb_6543bf898d8bb665 log69263e4windows+amd done runHidden tester1
jb_b700ae1fa635ebf8 log69263e4linux+nvidia cancelled prefetchNerdtality/agent-a30c861 superseded by a new push
jb_0a7a77c6a4959e7a log69263e4amd+igpu cancelled build-baseAONE/agent-431b421 superseded by a new push
jb_098285fe6d65fcd8 log69263e4linux+intel cancelled—0 superseded by a new push
jb_504bc36f19a71a29 log69263e4linux+nvidia done runHidden tester1
jb_870ceb872cf4991f log69263e4windows+amd cancelled—0 superseded by a new push
jb_70380dbf91f5cbf9 log69263e4linux+intel cancelled—0 superseded by a new push
jb_d89f64887454777d log69263e4steamdeck cancelled—0 superseded by a new push
jb_335501c7f8c5f35b log69263e4steamdeck cancelled—0 superseded by a new push
jb_a49b3600441495d2 log21b606ewindows+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt done reportHidden tester1
jb_cd2a97fbd25fb28e log21b606elinux+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt done reportAlberania/agent-af6cf31
jb_fd9d86b4990f8840 log21b606ewindows+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt cancelled—0 superseded by a new push
jb_37c5b6b62fb0afb3 log21b606elinux+amd+gpu-rx-7900-xtx_rx-9060-xt_rx-9070-xt cancelled—0 superseded by a new push
jb_e5c82b6dd727685d log21b606elinux+amd done reportSweatyEggs69/agent-cf0be71
jb_921143c6b63e99d6 log21b606ewindows+intel cancelled—0 re-planned by HumanBean
jb_a1ffb54fc0a4cc42 log21b606ewindows+intel cancelled—0 re-planned by HumanBean
jb_a0a3cd17ec346b7b log21b606elinux+nvidia cancelled—0 re-planned by HumanBean
jb_b2c359a644e50e6b log21b606elinux+intel cancelled—0 re-planned by HumanBean
jb_ed4215c118e26fba log21b606elinux+intel cancelled—0 re-planned by HumanBean
jb_6d31aa3647ada28e log21b606esteamdeck cancelled—0 re-planned by HumanBean
jb_c02deaab0ffaa464 log21b606eamd+igpu done reportFlashman4/agent-0e17b11
jb_fca19761a0839dc5 log21b606elinux+nvidia done runHidden tester1
jb_beb80e80b7523c8a log21b606ewindows+nvidia done reportFlashman4/agent-de36c51
jb_f0dccc83d8127bb6 log21b606eamd+igpu done reportHidden tester1
jb_a140e207eff818e1 log21b606ewindows+amd cancelled build-basepickaxe/agent-607ffe1 re-planned by HumanBean
jb_21799cd2e6ae07ff log21b606ewindows+nvidia done build-baseCubanLegend/agent-3419241
jb_064bdfb498aaabb9 log21b606elinux+amd cancelled build-pricyblue8/agent-368f001 re-planned by HumanBean
jb_082b57e5ea843017 log21b606ewindows+amd done reportHidden tester1
jb_db1bb6698bd2870c log21b606esteamdeck done reportFlashman4/agent-0e17b11
jb_3e4ab5747f3c9dbc loga2cc7b5linux+nvidia off target done reportCubanLegend/agent-3419241
jb_10da33d70de7ce3b loga2cc7b5steamdeck cancelled—1 superseded by a new push
jb_c79f2be2a0a7276e loga2cc7b5linux+intel cancelled—0 superseded by a new push
jb_12304896c8800630 loga2cc7b5amd+igpu done reportHidden tester1
jb_646703eeb1d10ea8 loga2cc7b5linux+intel cancelled—0 superseded by a new push
jb_6188ca5698afc253 loga2cc7b5linux+amd done reportHidden tester1
jb_8d4d05a37e14ee46 loga2cc7b5windows+intel cancelled—0 superseded by a new push
jb_b913bbee15b04f5d loga2cc7b5windows+nvidia done build-baseHidden tester1
jb_05f9d41dec02ee58 loga2cc7b5steamdeck cancelled build-prFlashman4/agent-0e17b11 superseded by a new push
jb_19e624f98a68503c loga2cc7b5linux+amd done reportAlberania/agent-af6cf31
jb_e2333b5113a2b248 loga2cc7b5windows+intel cancelled—0 superseded by a new push
jb_133ec59b0af4f6b7 loga2cc7b5amd+igpu done reportHidden tester1
jb_d6b16583e7e4b5cf loga2cc7b5linux+nvidia cancelled—0 superseded by a new push
jb_975e30a449ffa1d5 loga2cc7b5windows+amd cancelled build-basepickaxe/agent-607ffe6 superseded by a new push
jb_b6c896b6e3f7c5e0 loga2cc7b5windows+nvidia done reportFlashman4/agent-de36c52 passing, tried again: fetch: git clone failed: Cloning into '<data>\longshot'... fatal: unable to access 'https://git.magicbean.dev/MagicBeanDev/Longshot.git/': schannel: next InitializeSecurityContext failed: CRYPT_E_REVOCATION_OFFLINE (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline. (tried 4 times)
jb_583f3b18ab86c2b1 loga2cc7b5windows+amd done reportRazytos/agent-d8f9021
jb_9682de3a3718cf27 loga2cc7b5linux+nvidia done runHidden tester1
jb_690d0f4d23e8cd3c log85c0d23linux+nvidia off target cancelled prefetchakkusativ/agent-0a71fc1 build-base: the agent failed: WinError: SetNamedSecurityInfoW (the low integrity label on <data>\base-home): error 5 (0x5, Zugriff verweigert)
jb_665b0c1a893ead12 log85c0d23steamdeck cancelled—0 superseded by a new push
jb_6cb208b9ea461eff log85c0d23amd+igpu cancelled build-baseHidden tester2 superseded by a new push
jb_8ad2b3dd7c173687 log85c0d23windows+nvidia done reportthebasedpisces/agent-8d29991
jb_3acb23c479d03b61 log85c0d23linux+nvidia cancelled runHidden tester1 superseded by a new push
jb_7c7f1d525c7b1d91 log85c0d23amd+igpu cancelled prefetchHidden tester2 superseded by a new push
jb_7019ff3f2161146d log85c0d23steamdeck cancelled—0 superseded by a new push
jb_06fb66a875c17c97 log85c0d23windows+intel cancelled—0 superseded by a new push
jb_4b1e6b378e12a0b4 log85c0d23linux+nvidia cancelled—0 superseded by a new push
jb_ff1b760303c16cc8 log85c0d23windows+intel cancelled—0 superseded by a new push
jb_de09b3bf561afc15 log85c0d23windows+nvidia done build-baseHidden tester1
jb_a6bdce24b83cdfde log85c0d23linux+amd done reportSweatyEggs69/agent-cf0be71
jb_97af62b69671e371 log85c0d23windows+amd cancelled—3 superseded by a new push
jb_7f74a0edd9854520 log85c0d23linux+amd done reportAlberania/agent-af6cf31