#1745 perf(vk): the recorder thread spins 5 ms before it sleeps on Intel CPUs, which keeps their clock up
Commit
Plan (gpt-6.1-terra)
Compare recorder spin performance across three scenes
In plain words
Two starts per side compare main and the PR in Kokiri Forest, Hyrule Field and the Market, with V-Sync off and the frame-rate cap uncapped. Each scene is measured for 15 seconds standing and 10 seconds after a camera turn; the plan cannot measure while the stick input is running. Lower FPS, more frames over 50 ms, a missing recorder-spin log or a crash fails the PR. CPU core count and vendor cannot be targeted directly, and the shared log rule accepts either spin rather than enforcing the CPU-specific choice. The requested Intel-GPU targets have no matching online hardware listed and will remain pending until matching hardware is available. No tester online now matches windows+intel, linux+intel: those targets wait for one.
Asked for
the PR changed: the 5 ms spin is now the default on Intel CPUs only (AMD CPUs keep main's adaptive spin; it cost 3-11% on a Ryzen 9 7900X). Please test this PR against main on PCs whose CPU has 6 or more cores, preferring Intel CPUs: windows+intel, linux+intel, and windows+nvidia / windows+amd / linux+amd / linux+nvidia testers with an Intel CPU where there are some; on an AMD CPU expect no change. Settings vsync=2 (Off) and frame_rate_cap=6 (Uncapped), defaults otherwise. From the `kokiri-start` save: Kokiri Forest, Hyrule Field and Castle Town Market, in each 15 s standing then 10 s turning the camera, two game starts a side. Expect fps no lower than main and no more frames over 50 ms; the log's `RX_VK_RECORDER=thread` line shows `spin 5000 us` on Intel and `spin adaptive 20-200 us` on AMD.
Raw plan Download plan.json
{
"pass": {
"crash": false,
"fps_mean": {
"min_delta_pct": 0
},
"hitch_count": {
"max_delta_pct": 0
},
"log_forbidden_hits": {
"max": 0
},
"log_expected_missing": {
"max": 0
}
},
"probe": [
{
"kind": "crash"
},
{
"kind": "frametime"
},
{
"kind": "draws"
},
{
"kind": "log_match",
"expected": [
"RX_VK_RECORDER=thread: .*spin (5000 us|adaptive 20-200 us)"
],
"forbidden": [
"vk: device lost"
]
}
],
"matrix": {},
"schema": 3,
"target": [
{
"name": "windows+intel",
"tags": [
"windows",
"intel"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+intel",
"tags": [
"linux",
"intel"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+nvidia",
"tags": [
"windows",
"nvidia"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+amd",
"tags": [
"windows",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+amd",
"tags": [
"linux",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "linux+nvidia",
"tags": [
"linux",
"nvidia"
],
"max_reports": 2,
"min_reports": 1
}
],
"summary": "Compare recorder spin performance across three scenes",
"baseline": {
"ref": "main"
},
"scenario": [
{
"env": {},
"name": "recorder-scenes",
"runs": 2,
"step": [
{
"do": "teleport",
"to": "KokiriForest_Child"
},
{
"do": "wait",
"map": "KokiriForest_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "kokiri-still",
"warmup_s": 10,
"duration_s": 15
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"do": "measure",
"name": "kokiri-after-turn",
"warmup_s": 0,
"duration_s": 10
},
{
"do": "teleport",
"to": "HyruleField_Child"
},
{
"do": "wait",
"map": "HyruleField_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "field-still",
"warmup_s": 10,
"duration_s": 15
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"do": "measure",
"name": "field-after-turn",
"warmup_s": 0,
"duration_s": 10
},
{
"do": "teleport",
"to": "Market_Child"
},
{
"do": "wait",
"map": "Market_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "market-still",
"warmup_s": 10,
"duration_s": 15
},
{
"x": 1,
"y": 0,
"do": "stick",
"stick": "R",
"frames": 600
},
{
"do": "measure",
"name": "market-after-turn",
"warmup_s": 0,
"duration_s": 10
}
],
"start": "save:kokiri-start",
"matrix": true,
"settings": {
"vsync": 2,
"frame_rate_cap": 6
}
}
]
}
Targets
| Target | Tier | Reports | Status |
|---|---|---|---|
| windows+intel | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| linux+intel | reviewed HumanBean | none yet | 0/1 pass, 0 running, 0 queued |
| windows+nvidia | reviewed HumanBean | 1 2 | 1/1 fail |
| windows+amd | reviewed HumanBean | 1 2 | 1/1 fail |
| linux+amd | reviewed HumanBean | 1 2 | 2/1 fail |
| linux+nvidia | reviewed HumanBean | 1 2 | 2/1 fail |
Reports
Jobs
| Job | Commit | Target | State | Tester | Started | Attempts | Estimate | Note |
|---|---|---|---|---|---|---|---|---|
jb_7bce73379df627b9 log | 78d3259 | linux+intel off target | done run | Hidden tester | 1 | |||
jb_356dbdcde0cebc3e log | 78d3259 | windows+intel | cancelled | — | 0 | the PR was closed | ||
jb_a9f4f30ae633b658 log | 78d3259 | linux+intel | cancelled | — | 0 | the PR was closed | ||
jb_c480b2f1dd7e7095 log | 78d3259 | linux+intel | cancelled | — | 0 | the PR was closed | ||
jb_8e595e9b7b2b95fe log | 78d3259 | windows+nvidia | done run | thebasedpisces/agent-8d2999 | 1 | |||
jb_4c0f3da31d3e870e log | 78d3259 | linux+nvidia | done run | DuckNintendo/linux-4090 | 1 | |||
jb_e93b86db11dd9059 log | 78d3259 | windows+amd | done run | KellDraygo/agent-eb6ce1 | 4 | lease expired, tried again: the tester missed its heartbeats | ||
jb_da7dd01e0bfd0489 log | 78d3259 | linux+amd | done report | Alberania/agent-af6cf3 | 1 | |||
jb_257a258817d26a1f log | 78d3259 | windows+nvidia | done build-pr | akkusativ/agent-0a71fc | 1 | |||
jb_504795ed7dc993cb log | 78d3259 | linux+nvidia | done run | Hidden tester | 1 | |||
jb_77c0bd74d9238e16 log | 78d3259 | linux+amd | done report | SweatyEggs69/agent-cf0be7 | 1 | |||
jb_214576e95c6770a9 log | 78d3259 | windows+intel | cancelled | — | 0 | the PR was closed | ||
jb_69cfc56e7ccdc56b log | 78d3259 | windows+amd | done build-base | Hidden tester | 6 | setup: Could not access your .nup file: it is not where it was. Check that the file is still there, reconnect its drive if needed, or choose it again in Settings. | ||
jb_7914dbe250871115 log | bd4df97 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_428f2947d383e0e7 log | bd4df97 | linux+nvidia | cancelled run | Hidden tester | 1 | superseded by a new push | ||
jb_8e6521aa9d4ced33 log | bd4df97 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_579b75a60da73b56 log | bd4df97 | windows+amd | done build-base | Hidden tester | 1 | |||
jb_ba175963f9449975 log | bd4df97 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_30a1dc6c9d6a90c6 log | bd4df97 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_63d9b10636b3aae0 log | bd4df97 | linux+amd | done report | Flashman4/agent-0e17b1 | 1 | |||
jb_3f7aa81c56a50158 log | bd4df97 | linux+cpu-ryzen-* | done report | Hidden tester | 1 | |||
jb_11861a2890c97ab4 log | bd4df97 | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_3b8f2fe692656d18 log | bd4df97 | linux+amd | done report | Alberania/agent-af6cf3 | 1 | |||
jb_1a170251607ea75c log | bd4df97 | linux+nvidia | done run | jabbaxipil/Blaine | 1 | |||
jb_b7e74cee0a09b53f log | bd4df97 | linux+cpu-ryzen-* | done report | Alberania/agent-af6cf3 | 1 | |||
jb_2ba88c57575ffed7 log | bd4df97 | windows+nvidia | done report | Flashman4/agent-de36c5 | 1 | |||
jb_38ca5609cbfc564e log | bd4df97 | windows+amd | cancelled | — | 3 | superseded by a new push | ||
jb_44f50b2d3e98da96 log | e855d37 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_fc29889498ae11cd log | e855d37 | linux+nvidia | cancelled build-base | Hidden tester | 1 | superseded by a new push | ||
jb_419fb86190192f67 log | e855d37 | linux+amd | cancelled run | Alberania/agent-af6cf3 | 1 | superseded by a new push | ||
jb_14012d7acca156e0 log | e855d37 | linux+nvidia | cancelled run | jabbaxipil/Blaine | 1 | superseded by a new push | ||
jb_914f4107ee416ea2 log | e855d37 | linux+amd | cancelled build-base | Flashman4/agent-0e17b1 | 1 | superseded by a new push | ||
jb_1b5032af16359637 log | e855d37 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_4d37a404f3e72626 log | e855d37 | linux+amd+cpu-ryzen-* | cancelled | — | 0 | re-planned by HumanBean | ||
jb_8f733a0c99e10a2a log | e855d37 | windows | cancelled build-base | Flashman4/agent-de36c5 | 2 | re-planned by HumanBean | ||
jb_31e6a6c7cb5a6e53 log | e855d37 | linux+amd+cpu-ryzen-* | cancelled run | Alberania/agent-af6cf3 | 1 | re-planned by HumanBean | ||
jb_c3e098c64949d85e log | e855d37 | windows | done build-base | Hidden tester | 2 | prefetch: less than 30.0 GB free on the work folder's disk |