Beanstalk Longshot test farm
Menu

#1745 perf(vk): the recorder thread spins 5 ms before it sleeps on Intel CPUs, which keeps their clock up

by HumanBean closed Open on Forgejo

Commit

Head
78d3259
Base
main d5794c8
Approval
approved HumanBean, · reviewed

Plan (gpt-6.1-terra)

Compare recorder spin performance across three scenes

In plain words

Two starts per side compare main and the PR in Kokiri Forest, Hyrule Field and the Market, with V-Sync off and the frame-rate cap uncapped. Each scene is measured for 15 seconds standing and 10 seconds after a camera turn; the plan cannot measure while the stick input is running. Lower FPS, more frames over 50 ms, a missing recorder-spin log or a crash fails the PR. CPU core count and vendor cannot be targeted directly, and the shared log rule accepts either spin rather than enforcing the CPU-specific choice. The requested Intel-GPU targets have no matching online hardware listed and will remain pending until matching hardware is available. No tester online now matches windows+intel, linux+intel: those targets wait for one.

Asked for

the PR changed: the 5 ms spin is now the default on Intel CPUs only (AMD CPUs keep main's adaptive spin; it cost 3-11% on a Ryzen 9 7900X). Please test this PR against main on PCs whose CPU has 6 or more cores, preferring Intel CPUs: windows+intel, linux+intel, and windows+nvidia / windows+amd / linux+amd / linux+nvidia testers with an Intel CPU where there are some; on an AMD CPU expect no change. Settings vsync=2 (Off) and frame_rate_cap=6 (Uncapped), defaults otherwise. From the `kokiri-start` save: Kokiri Forest, Hyrule Field and Castle Town Market, in each 15 s standing then 10 s turning the camera, two game starts a side. Expect fps no lower than main and no more frames over 50 ms; the log's `RX_VK_RECORDER=thread` line shows `spin 5000 us` on Intel and `spin adaptive 20-200 us` on AMD.

Raw plan 201 lines Download plan.json

  "pass" 
    "crash" false
    "fps_mean" 
      "min_delta_pct" 0
    
    "hitch_count" 
      "max_delta_pct" 0
    
    "log_forbidden_hits" 
      "max" 0
    
    "log_expected_missing" 
      "max" 0
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
    
      "kind" "draws"
    
    
      "kind" "log_match"
      "expected" 
        "RX_VK_RECORDER=thread: .*spin (5000 us|adaptive 20-200 us)"
      
      "forbidden" 
        "vk: device lost"
      
    
  
  "matrix" 
  "schema" 3
  "target" 
    
      "name" "windows+intel"
      "tags" 
        "windows"
        "intel"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+intel"
      "tags" 
        "linux"
        "intel"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+nvidia"
      "tags" 
        "windows"
        "nvidia"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+amd"
      "tags" 
        "windows"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+amd"
      "tags" 
        "linux"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+nvidia"
      "tags" 
        "linux"
        "nvidia"
      
      "max_reports" 2
      "min_reports" 1
    
  
  "summary" "Compare recorder spin performance across three scenes"
  "baseline" 
    "ref" "main"
  
  "scenario" 
    
      "env" 
      "name" "recorder-scenes"
      "runs" 2
      "step" 
        
          "do" "teleport"
          "to" "KokiriForest_Child"
        
        
          "do" "wait"
          "map" "KokiriForest_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "kokiri-still"
          "warmup_s" 10
          "duration_s" 15
        
        
          "x" 1
          "y" 0
          "do" "stick"
          "stick" "R"
          "frames" 600
        
        
          "do" "measure"
          "name" "kokiri-after-turn"
          "warmup_s" 0
          "duration_s" 10
        
        
          "do" "teleport"
          "to" "HyruleField_Child"
        
        
          "do" "wait"
          "map" "HyruleField_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "field-still"
          "warmup_s" 10
          "duration_s" 15
        
        
          "x" 1
          "y" 0
          "do" "stick"
          "stick" "R"
          "frames" 600
        
        
          "do" "measure"
          "name" "field-after-turn"
          "warmup_s" 0
          "duration_s" 10
        
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "market-still"
          "warmup_s" 10
          "duration_s" 15
        
        
          "x" 1
          "y" 0
          "do" "stick"
          "stick" "R"
          "frames" 600
        
        
          "do" "measure"
          "name" "market-after-turn"
          "warmup_s" 0
          "duration_s" 10
        
      
      "start" "save:kokiri-start"
      "matrix" true
      "settings" 
        "vsync" 2
        "frame_rate_cap" 6
      
    
  

Targets

TargetTierReportsStatus
windows+intelreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
linux+intelreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
windows+nvidiareviewed HumanBean 1 2 1/1 fail
windows+amdreviewed HumanBean 1 2 1/1 fail
linux+amdreviewed HumanBean 1 2 2/1 fail
linux+nvidiareviewed HumanBean 1 2 2/1 fail

Reports

ReportCommitTargetTesterResultWhen
rp_a0498857d73064d978d3259linux+intel Hidden testerfail off target
rp_5a1191aa883ea96578d3259windows+amd Hidden testererror
rp_8a67295ba518490178d3259windows+amd KellDraygo/agent-eb6ce1fail
rp_d485034ddb4f582678d3259linux+nvidia Hidden testerfail
rp_a81c68523b1b675878d3259windows+nvidia thebasedpisces/agent-8d2999fail
rp_108e7eeb0cbf0c4e78d3259linux+nvidia DuckNintendo/linux-4090fail
rp_a5c5dfc05e8a05cc78d3259windows+nvidia akkusativ/agent-0a71fcerror
rp_a87bd3941b74d4d578d3259linux+amd SweatyEggs69/agent-cf0be7fail outlier
rp_ca4244d1242f55af78d3259linux+amd Alberania/agent-af6cf3fail outlier
rp_70fef5f97c75247abd4df97linux+cpu-ryzen-* Hidden testerfail outlier
rp_261b1e9d7ad5d411bd4df97windows+nvidia Flashman4/agent-de36c5fail
rp_a2dd0e666d132822bd4df97linux+nvidia jabbaxipil/Blainefail
rp_d072671692b40a29bd4df97linux+amd Flashman4/agent-0e17b1fail outlier
rp_0aea16740f59b27fbd4df97linux+cpu-ryzen-* Alberania/agent-af6cf3fail outlier
rp_abf028383aacba39bd4df97linux+amd Alberania/agent-af6cf3fail outlier
rp_892184c638a55487bd4df97windows+amd Hidden testererror
rp_0a924842278c9849bd4df97windows+nvidia Hidden testererror
rp_4a0a8ec6755f62f8e855d37windows Hidden testererror

Jobs

JobCommitTargetStateTesterStartedAttemptsEstimateNote
jb_7bce73379df627b9 log78d3259linux+intel off target done runHidden tester1
jb_356dbdcde0cebc3e log78d3259windows+intel cancelled—0 the PR was closed
jb_a9f4f30ae633b658 log78d3259linux+intel cancelled—0 the PR was closed
jb_c480b2f1dd7e7095 log78d3259linux+intel cancelled—0 the PR was closed
jb_8e595e9b7b2b95fe log78d3259windows+nvidia done runthebasedpisces/agent-8d29991
jb_4c0f3da31d3e870e log78d3259linux+nvidia done runDuckNintendo/linux-40901
jb_e93b86db11dd9059 log78d3259windows+amd done runKellDraygo/agent-eb6ce14 lease expired, tried again: the tester missed its heartbeats
jb_da7dd01e0bfd0489 log78d3259linux+amd done reportAlberania/agent-af6cf31
jb_257a258817d26a1f log78d3259windows+nvidia done build-prakkusativ/agent-0a71fc1
jb_504795ed7dc993cb log78d3259linux+nvidia done runHidden tester1
jb_77c0bd74d9238e16 log78d3259linux+amd done reportSweatyEggs69/agent-cf0be71
jb_214576e95c6770a9 log78d3259windows+intel cancelled—0 the PR was closed
jb_69cfc56e7ccdc56b log78d3259windows+amd done build-baseHidden tester6 setup: Could not access your .nup file: it is not where it was. Check that the file is still there, reconnect its drive if needed, or choose it again in Settings.
jb_7914dbe250871115 logbd4df97linux+intel cancelled—0 superseded by a new push
jb_428f2947d383e0e7 logbd4df97linux+nvidia cancelled runHidden tester1 superseded by a new push
jb_8e6521aa9d4ced33 logbd4df97linux+intel cancelled—0 superseded by a new push
jb_579b75a60da73b56 logbd4df97windows+amd done build-baseHidden tester1
jb_ba175963f9449975 logbd4df97windows+intel cancelled—0 superseded by a new push
jb_30a1dc6c9d6a90c6 logbd4df97windows+intel cancelled—0 superseded by a new push
jb_63d9b10636b3aae0 logbd4df97linux+amd done reportFlashman4/agent-0e17b11
jb_3f7aa81c56a50158 logbd4df97linux+cpu-ryzen-* done reportHidden tester1
jb_11861a2890c97ab4 logbd4df97windows+nvidia done build-baseHidden tester1
jb_3b8f2fe692656d18 logbd4df97linux+amd done reportAlberania/agent-af6cf31
jb_1a170251607ea75c logbd4df97linux+nvidia done runjabbaxipil/Blaine1
jb_b7e74cee0a09b53f logbd4df97linux+cpu-ryzen-* done reportAlberania/agent-af6cf31
jb_2ba88c57575ffed7 logbd4df97windows+nvidia done reportFlashman4/agent-de36c51
jb_38ca5609cbfc564e logbd4df97windows+amd cancelled—3 superseded by a new push
jb_44f50b2d3e98da96 loge855d37linux+intel cancelled—0 superseded by a new push
jb_fc29889498ae11cd loge855d37linux+nvidia cancelled build-baseHidden tester1 superseded by a new push
jb_419fb86190192f67 loge855d37linux+amd cancelled runAlberania/agent-af6cf31 superseded by a new push
jb_14012d7acca156e0 loge855d37linux+nvidia cancelled runjabbaxipil/Blaine1 superseded by a new push
jb_914f4107ee416ea2 loge855d37linux+amd cancelled build-baseFlashman4/agent-0e17b11 superseded by a new push
jb_1b5032af16359637 loge855d37linux+intel cancelled—0 superseded by a new push
jb_4d37a404f3e72626 loge855d37linux+amd+cpu-ryzen-* cancelled—0 re-planned by HumanBean
jb_8f733a0c99e10a2a loge855d37windows cancelled build-baseFlashman4/agent-de36c52 re-planned by HumanBean
jb_31e6a6c7cb5a6e53 loge855d37linux+amd+cpu-ryzen-* cancelled runAlberania/agent-af6cf31 re-planned by HumanBean
jb_c3e098c64949d85e loge855d37windows done build-baseHidden tester2 prefetch: less than 30.0 GB free on the work folder's disk