#1702 perf(vk): the presenter thread on by default with NVIDIA on Linux and AMD on Windows, with NVIDIA Reflex; after #1121
Commit
Plan (gpt-6.1-terra)
Windows AMD and NVIDIA presenter defaults and uncapped FPS in Kokiri Forest and Market
In plain words
Compare the PR with main on Windows AMD and NVIDIA PCs, with V-Sync off and the frame rate uncapped. Each of two starts per side visits Kokiri Forest and Castle Town Market, measuring 15 seconds standing and 10 seconds after moving at each location; the run takes about 22 minutes per tester. The PR fails on a crash, device loss, a sampled picture difference, or FPS below main in any segment. The log check accepts either requested presenter-thread message, but cannot enforce the AMD and NVIDIA expectations separately in one shared plan.
Asked for
run 5, again for the new head 28f5fb2 (the same code: #1121 now sits under it as its own PR; run 4 failed because main did not build on Windows, fixed by #1729). The last commit turns the presenter thread on by default with AMD's Windows driver on a discrete card. Please test this PR against main on windows+amd and windows+nvidia, settings vsync=2 (Off) and frame_rate_cap=6 (Uncapped), no switches: Kokiri Forest and Castle Town Market, standing 15 s and 10 s after moving, two game starts a side. Expect `vk: presenter thread: each present made on a thread` in the log on AMD and `off (RX_VK_PRESENT_THREAD=1: on)` on NVIDIA, and fps at least main's on both.
Raw plan Download plan.json
{
"pass": {
"crash": false,
"fps_mean": {
"min_delta_pct": 0
},
"screenshot": {
"max_diff": 0.2
},
"log_forbidden_hits": {
"max": 0
},
"log_expected_missing": {
"max": 0
}
},
"probe": [
{
"kind": "crash"
},
{
"kind": "draws"
},
{
"kind": "frametime"
},
{
"kind": "log_match",
"expected": [
"vk: presenter thread: each present made on a thread|off \\(RX_VK_PRESENT_THREAD=1: on\\)"
],
"forbidden": [
"vk: device lost"
]
}
],
"matrix": {},
"schema": 3,
"target": [
{
"name": "windows+amd",
"tags": [
"windows",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+nvidia",
"tags": [
"windows",
"nvidia"
],
"max_reports": 2,
"min_reports": 1
}
],
"summary": "Windows AMD and NVIDIA presenter defaults and uncapped FPS in Kokiri Forest and Market",
"baseline": {
"ref": "main"
},
"scenario": [
{
"env": {},
"name": "forest-and-market",
"runs": 2,
"step": [
{
"do": "teleport",
"to": "KokiriForest_Child"
},
{
"do": "wait",
"map": "KokiriForest_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "forest-standing",
"warmup_s": 5,
"duration_s": 15
},
{
"do": "shot",
"name": "forest",
"upload": false,
"compare": "baseline"
},
{
"x": 0,
"y": 1,
"do": "stick",
"stick": "L",
"frames": 150
},
{
"do": "measure",
"name": "forest-after-moving",
"warmup_s": 0,
"duration_s": 10
},
{
"do": "teleport",
"to": "Market_Child"
},
{
"do": "wait",
"map": "Market_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "market-standing",
"warmup_s": 5,
"duration_s": 15
},
{
"do": "shot",
"name": "market",
"upload": false,
"compare": "baseline"
},
{
"x": 0,
"y": 1,
"do": "stick",
"stick": "L",
"frames": 150
},
{
"do": "measure",
"name": "market-after-moving",
"warmup_s": 0,
"duration_s": 10
}
],
"start": "save:kokiri-start",
"matrix": true,
"settings": {
"vsync": 2,
"frame_rate_cap": 6
}
}
]
}
Targets
Reports
Jobs
| Job | Commit | Target | State | Tester | Started | Attempts | Estimate | Note |
|---|---|---|---|---|---|---|---|---|
jb_718419a9177a120e log | 28f5fb2 | windows+amd | done build-base | Hidden tester | 4 | setup: Could not access your .nup file: it is not where it was. Check that the file is still there, reconnect its drive if needed, or choose it again in Settings. | ||
jb_6f071b862296e2d8 log | 28f5fb2 | windows+nvidia | done report | Flashman4/agent-de36c5 | 1 | |||
jb_a872aab13df2d891 log | 28f5fb2 | windows+amd | done build-base | KellDraygo/agent-eb6ce1 | 2 | prefetch: less than 30.0 GB free on the work folder's disk | ||
jb_9a8b98e7f4e07b45 log | 28f5fb2 | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_1bbe2605ec57dfc6 log | 0c38084 | linux+intel off target | cancelled run | Hidden tester | 1 | superseded by a new push | ||
jb_292a7ee1aa3485ff log | 0c38084 | windows+amd | done build-base | Hidden tester | 1 | |||
jb_a6591fcec6a32a2b log | 0c38084 | windows+amd | done build-base | Razytos/agent-d8f902 | 1 | |||
jb_1c49bec199482b42 log | 0c38084 | windows+nvidia | done report | Hidden tester | 1 | |||
jb_58e60feb3e2f04bb log | 0c38084 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_73e630c0f5a45433 log | 0c38084 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_ba3830f6fd125b75 log | 0c38084 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_fdd6cda28075b59f log | 0c38084 | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_0acb1454c1536934 log | 0c38084 | windows+nvidia | done build-base | Flashman4/agent-de36c5 | 1 | |||
jb_bc8d4519913a502e log | 3569b8d | linux+intel off target | cancelled run | Hidden tester | 1 | superseded by a new push | ||
jb_851f27ea93d33d4c log | 3569b8d | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_11821ba923ef1fe4 log | 3569b8d | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_766e98034e59f0eb log | 3569b8d | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_834d0ef914da105f log | 3569b8d | steamdeck | cancelled | — | 0 | superseded by a new push | ||
jb_7baf6cb3498b8021 log | 3569b8d | linux+intel | cancelled | — | 0 | superseded by a new push | ||
jb_4d3201ae8b3f88e6 log | 3569b8d | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_23d863037c761b45 log | 3569b8d | windows+nvidia | done report | Flashman4/agent-de36c5 | 1 | |||
jb_9b21cc79f76459e4 log | 3569b8d | linux+amd | done report | Alberania/agent-af6cf3 | 1 | |||
jb_e9152b3953bb4fdf log | 3569b8d | windows+amd | done report | Hidden tester | 2 | passing, tried again: prefetch: the agent failed: WinError: SetNamedSecurityInfoW (the low integrity label on <data>\game-home): error 5 (0x5, Access is denied) | ||
jb_101a46b59d131cc3 log | 3569b8d | steamdeck | done report | Flashman4/agent-0e17b1 | 1 | |||
jb_61e3e57de4276cbf log | 3569b8d | linux+amd | done report | Flashman4/agent-0e17b1 | 1 | |||
jb_cad9d677c60f0b82 log | 3569b8d | windows+amd | done report | Razytos/agent-d8f902 | 1 | |||
jb_61d1ebddb5d78ce8 log | 3569b8d | linux+amd | done report | Alberania/agent-af6cf3 | 1 | |||
jb_95407821d646906a log | 3569b8d | linux+amd | cancelled | — | 0 | re-planned by HumanBean | ||
jb_c0cc1fb54b4fc1ac log | 3569b8d | windows+nvidia | done report | thebasedpisces/agent-8d2999 | 1 | |||
jb_b769d6a826659138 log | 3569b8d | windows+nvidia | done build-base | Hidden tester | 1 | |||
jb_c16c2b9cff0394b5 log | 3569b8d | windows+amd | done report | Hidden tester | 1 | |||
jb_9465ac03f6c5dcbb log | 3569b8d | windows+amd | done report | Razytos/agent-d8f902 | 1 | |||
jb_6786ebf40de892b0 log | 3569b8d | windows+amd | cancelled | — | 0 | re-planned by HumanBean | ||
jb_0a8dd1d22c9c6446 log | 3569b8d | windows+amd | done report | Hidden tester | 1 |