Beanstalk Longshot test farm
Menu

#1681 perf(vk): render targets take a pooled image's memory by size, and the pool holds longer on integrated GPUs

by zeldaootr closed Open on Forgejo

Commit

Head
742b053
Base
main 068fb8e
Run
2
Approval
approved HumanBean, · reviewed

Plan (gpt-6.1-terra)

Compare render-target reuse levels during Hyrule Field camera turns and standing

In plain words

In Hyrule Field, the plan compares reuse levels 0, 1 and 2 on the PR build, with main also run because the memory-type safety check remains active at level 0. It turns the camera and then measures standing performance, captures pictures, and samples pool occupancy, reuse counts, VRAM and hitch metrics over roughly 35 minutes per tester. Crashes, device loss, large picture differences or a substantial standing p99 regression against level 0 fail the plan. Windows Intel waits for a matching tester; the farm cannot run windowed or measure lowest available system memory, and the turning input cannot overlap a timed measurement segment. No tester online now matches windows+intel: that target waits for one.

Asked for

please test this, to decide the real default of `RX_VK_TARGET_REUSE_MEMORY`. Same build of this PR, the switch as a matrix axis: `=0` (main's behavior), `=1` and `=2`, interleaved. Targets: windows+nvidia, windows+amd, windows+intel, linux+nvidia, linux+amd, steamdeck (igpu targets are where `=2` is the default today). Windowed, not headless, frame generation off: Hyrule Field with the camera turning full circle several times (Render 50% and 100% on the Deck and any iGPU), then standing. Report fps, 1% low, frames over 50 ms, p99, the pool's peak MB, lowest available memory and the log's `render target images:` line (`reused by size`), per level. We want to know if `=1`, `=2`, or off should be the default on each kind of PC (discrete, integrated, Deck), and whether any picture fault, device loss or memory pressure shows up.

Raw plan 202 lines Download plan.json

  "pass" 
    "crash" false
    "compare" 
      
        "axis" "RX_VK_TARGET_REUSE_MEMORY"
        "side" "pr"
        "value" "1"
        "metric" "frametime_p99_ms"
        "against" "0"
        "segment" "standing"
        "max_delta_pct" 20
      
      
        "axis" "RX_VK_TARGET_REUSE_MEMORY"
        "side" "pr"
        "value" "2"
        "metric" "frametime_p99_ms"
        "against" "0"
        "segment" "standing"
        "max_delta_pct" 20
      
    
    "screenshot" 
      "max_diff" 0.15
    
    "log_forbidden_hits" 
      "max" 0
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
    
      "kind" "draws"
    
    
      "kind" "vram"
    
    
      "kind" "log_match"
      "expected" 
      "forbidden" 
        "vk: device lost"
      
    
    
      "kind" "log_value"
      "value" 
        
          "name" "pool_mb"
          "take" "max"
          "pattern" "render target images: .* it holds [0-9]+ \\(([0-9]+) MB\\)"
        
        
          "name" "reused_by_size"
          "take" "max"
          "pattern" "render target images: .* ([0-9]+) reused by size"
        
      
    
  
  "matrix" 
    "pr_only" 
      "RX_VK_TARGET_REUSE_MEMORY" 
        "0"
        "1"
        "2"
      
    
  
  "schema" 8
  "target" 
    
      "name" "windows+nvidia"
      "tags" 
        "windows"
        "nvidia"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+amd"
      "tags" 
        "windows"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+intel"
      "tags" 
        "windows"
        "intel"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+nvidia"
      "tags" 
        "linux"
        "nvidia"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "linux+amd"
      "tags" 
        "linux"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "steamdeck"
      "tags" 
        "steamdeck"
      
      "max_reports" 2
      "min_reports" 1
    
  
  "summary" "Compare render-target reuse levels during Hyrule Field camera turns and standing"
  "baseline" 
    "ref" "main"
  
  "scenario" 
    
      "env" 
      "name" "field-turn-and-stand"
      "runs" 1
      "step" 
        
          "do" "teleport"
          "to" "HyruleField_Child"
        
        
          "do" "wait"
          "map" "HyruleField_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "wait_s"
          "seconds" 5
        
        
          "do" "shot"
          "name" "field-before"
          "upload" false
          "compare" "baseline"
        
        
          "do" "repeat"
          "step" 
            
              "x" 1
              "y" 0
              "do" "stick"
              "stick" "R"
              "frames" 600
            
          
          "count" 4
        
        
          "do" "shot"
          "name" "field-after-turn"
          "upload" false
          "compare" "baseline"
        
        
          "do" "measure"
          "name" "standing"
          "warmup_s" 5
          "duration_s" 25
        
        
          "do" "shot"
          "name" "field-standing"
          "upload" false
          "compare" "baseline"
        
      
      "start" "save:kokiri-start"
      "matrix" true
      "settings" 
        "fullscreen" 0
        "frame_generation" 0
      
    
  

Targets

TargetTierReportsStatus
windows+nvidiareviewed HumanBean 1 2 0/1 pass, 2 error
windows+amdreviewed HumanBean 1 2 1/1 fail
windows+intelreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued
linux+nvidiareviewed HumanBean 1 2 0/1 pass, 2 error
linux+amdreviewed HumanBean 1 2 0/1 pass, 2 error
steamdeckreviewed HumanBean none yet 0/1 pass, 0 running, 0 queued

Reports

ReportCommitTargetTesterResultWhen
rp_4318d582d0bc4d50742b053 run 2linux+amd McButt531/agent-b08055error outlier
rp_9a4f0a6f8dd38bb0742b053 run 2linux+amd manoouuu/agent-249cbcerror outlier
rp_f7636aec02a28f17742b053 run 2windows+amd Hellknight/agent-ff6c58fail outlier
rp_bc0d17a3bdb9533a742b053 run 2linux+nvidia Floppy/agent-06957cerror outlier
rp_96a0b2a0ff63df85742b053 run 2windows+amd Hidden testererror outlier
rp_b501478316215d49742b053 run 2linux+nvidia Nerdtality/agent-0452e3error outlier
rp_5fbbb71cda943ece742b053 run 2windows+nvidia llun/agent-481718error outlier
rp_6cee7735e34d343e742b053 run 2windows+nvidia Flashman4/agent-de36c5error outlier

Jobs

JobCommitTargetStateTesterStartedAttemptsEstimateNote
jb_e2318898bb7f020a log742b053windows+amd done reportHellknight/agent-ff6c581
jb_4c4e033c19f4a1ff log742b053linux+amd done reportmanoouuu/agent-249cbc7 prefetch: Input/output error : '<data>/jobs/jb_4c4e033c19f4a1ff'
jb_bf65fab375c3c465 log742b053linux+nvidia done reportFloppy/agent-06957c1
jb_badbc3e1638025b3 log742b053linux+amd done reportMcButt531/agent-b080559 setup: Your .nup could not be read (reading it stopped, exit 127): nice: ‘<data>/python/bin/python3’: No such file or directory
jb_0929dbc04fce253a log742b053windows+intel cancelled—0 the PR was closed
jb_078376ba11a88819 log742b053windows+amd done runHidden tester1
jb_9805e487eefa216b log742b053windows+intel cancelled—0 the PR was closed
jb_b71ab5e35e172dd4 log742b053steamdeck cancelled—0 the PR was closed
jb_e530a2b7bd5e48dd log742b053steamdeck cancelled—0 the PR was closed
jb_ff7b9571e212161e log742b053linux+nvidia done reportNerdtality/agent-0452e31
jb_765b5a77c775d49d log742b053windows+nvidia done reportFlashman4/agent-de36c53 build-base: git in the sandbox cannot read Longshot's checkout, so the build can't start (fail git rev-parse HEAD exited 128; fatal: could not open '/dev/null' for reading and writing: Permission denied; readable .git True; readable .git\HEAD True; readable .git\objects True; version). On this PC, `git -C <the data folder>\longshot rev-parse HEAD` shows the same, and that folder's permissions are the usual cause
jb_f6f95a6ec3ad568a log742b053windows+nvidia done reportllun/agent-4817185 build-base: git can't start in the sandbox, so the build can't start (fail git rev-parse HEAD exited 128; fatal: could not open '/dev/null' for reading and writing: Permission denied; readable .git True; readable .git\HEAD True; readable .git\objects True; version). git dies before it reads the checkout: the sandbox refuses it /dev/null (NUL). The app uses its own MinGit for this; if it still happens, tell the farm's team
jb_298c697e19272d76 log742b053any cancelled—2 re-planned by HumanBean
jb_4c7bed6c99308bf1 log742b053any cancelled—2 re-planned by HumanBean