#1552 WIP: fix(vk): the fixed shares' fallback upscale gets an edge pass and FSR 1 EASU
Commit
Plan (gpt-6.1-terra)
Compare fixed-share upscaling at 50% and 67% in Kokiri Forest and Hyrule Field on Windows AMD and Intel
In plain words
Windows AMD and Intel PCs will compare the PR with main in Kokiri Forest and Hyrule Field, using the game's own upscaler at both 50% and 67% render resolution. The resolution matrix exercises both changed fallback paths; screenshots capture Link's outline and the surroundings, while FPS and frame times measure performance over roughly 13 minutes per tester. Crashes, large screenshot differences, a 10% FPS drop, or a 15% p99 frame-time increase fail the plan; the image threshold permits some intended edge smoothing but cannot prove that outlines improved. No Intel tester is currently listed online, so that target will wait for one. No tester online now matches windows+intel: that target waits for one.
Asked for
windows amd and windows intel: this PR against main at Render resolution 50% and 67% with the game's own upscaler, Kokiri Forest and Hyrule Field, screenshots of Link's outline and fps
Raw plan Download plan.json
{
"pass": {
"crash": false,
"fps_mean": {
"min_delta_pct": 10
},
"screenshot": {
"max_diff": 0.15
},
"frametime_p99_ms": {
"max_delta_pct": 15
}
},
"probe": [
{
"kind": "crash"
},
{
"kind": "draws"
},
{
"kind": "frametime"
}
],
"matrix": {
"resolution": [
4,
3
]
},
"schema": 3,
"target": [
{
"name": "windows+amd",
"tags": [
"windows",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+intel",
"tags": [
"windows",
"intel"
],
"max_reports": 2,
"min_reports": 1
}
],
"summary": "Compare fixed-share upscaling at 50% and 67% in Kokiri Forest and Hyrule Field on Windows AMD and Intel",
"baseline": {
"ref": "main"
},
"scenario": [
{
"env": {},
"name": "outlines-and-fps",
"runs": 1,
"step": [
{
"do": "teleport",
"to": "KokiriForest_Child"
},
{
"do": "wait",
"map": "KokiriForest_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "forest",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "forest-outline",
"upload": false,
"compare": "baseline"
},
{
"do": "teleport",
"to": "HyruleField_Child"
},
{
"do": "wait",
"map": "HyruleField_Child",
"event": "map",
"timeout_s": 60
},
{
"do": "measure",
"name": "field",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "shot",
"name": "field-outline",
"upload": false,
"compare": "baseline"
}
],
"start": "new",
"matrix": true,
"settings": {
"dlss": 0,
"frame_generation": 0
}
}
]
}
Targets
Reports
| Report | Commit | Target | Tester | Result | When |
|---|---|---|---|---|---|
| rp_3043e2ab95b4174d | ff0eec7 | windows+amd | Razytos/agent-d8f902 | pass outlier | |
| rp_071ec9da9d0d00a0 | ff0eec7 | windows+amd | Hidden tester | pass outlier |
Jobs
| Job | Commit | Target | State | Tester | Started | Attempts | Estimate | Note |
|---|---|---|---|---|---|---|---|---|
jb_e53027dbd4d99f25 log | ff0eec7 | windows+amd | done run | Hidden tester | 1 | |||
jb_2505e84d188607ea log | ff0eec7 | windows+amd | done report | Razytos/agent-d8f902 | 1 | |||
jb_7d497a91d13a4cd7 | ff0eec7 | windows+intel | queued | — | 0 | No tester online can take it now. | No tester online matches `windows+intel`. | |
jb_30ef552e2a723201 | ff0eec7 | windows+intel | queued | — | 0 | No tester online can take it now. | No tester online matches `windows+intel`. |