#1488 perf(vk): let go of the shader modules of ready programs after the start on Windows too, on request (#1474)
Commit
Plan (gpt-6.1-terra)
Compare Windows precompile shader-module release off and on in Hyrule Field and the Market
In plain words
On Windows, the plan compares shader-module release off and on after the start-up precompile, using a 16 GB PC, an AMD GPU and an Intel Arc GPU. Intel Arc has no matching tester currently online, so that target will wait. Each target takes roughly 20–25 minutes and visits Hyrule Field and the Market, recording pictures, frame times, working-set memory and the release's private-memory log values. Crashes, failed module remakes, large picture differences, or specified performance and memory regressions fail the plan; the log values also show whether modules were released and how private memory changed across the release. No tester online now matches windows+intel+gpu-arc-*: that target waits for one.
Raw plan Download plan.json
{
"pass": {
"crash": false,
"compare": [
{
"axis": "RX_VK_DROP_MODULES",
"side": "pr",
"value": "1",
"metric": "rss_peak_mb",
"against": "0",
"max_delta_pct": 10
},
{
"axis": "RX_VK_DROP_MODULES",
"side": "pr",
"value": "1",
"metric": "frametime_p99_ms",
"against": "0",
"max_delta_pct": 20
}
],
"screenshot": {
"max_diff": 0.15
},
"load_time_max_s": {
"max_delta_pct": 30
},
"frametime_p99_ms": {
"max_delta_pct": 20
},
"log_forbidden_hits": {
"max": 0
}
},
"probe": [
{
"kind": "crash"
},
{
"kind": "frametime"
},
{
"kind": "process"
},
{
"kind": "load_time"
},
{
"kind": "log_match",
"expected": [],
"forbidden": [
"vk: device lost",
"[1-9][0-9]* could not be made again"
]
},
{
"kind": "log_value",
"value": [
{
"name": "modules",
"none": 0,
"take": "max",
"pattern": "vk: programs: ([0-9]+) shader modules let go after the precompile"
},
{
"name": "private_before_mb",
"take": "max",
"pattern": "private memory went ([0-9]+) -> [0-9]+ MB"
},
{
"name": "private_after_mb",
"take": "max",
"pattern": "private memory went [0-9]+ -> ([0-9]+) MB"
},
{
"name": "release_ms",
"take": "max",
"pattern": "the release took ([0-9.]+) ms"
}
]
}
],
"matrix": {
"RX_VK_DROP_MODULES": [
"0",
"1"
]
},
"schema": 8,
"target": [
{
"name": "windows+ram16gb",
"tags": [
"windows"
],
"ram_gb": 16,
"max_reports": 2,
"min_reports": 1
},
{
"name": "windows+amd",
"tags": [
"windows",
"amd"
],
"max_reports": 2,
"min_reports": 1
},
{
"gpu": [
"arc *"
],
"name": "windows+intel+gpu-arc-*",
"tags": [
"windows",
"intel"
],
"max_reports": 2,
"min_reports": 1
}
],
"summary": "Compare Windows precompile shader-module release off and on in Hyrule Field and the Market",
"baseline": {
"ref": "main"
},
"scenario": [
{
"env": {
"RX_VK_LOAD": "start",
"RX_VK_PRECOMPILE": "1",
"RX_VK_LOG_PROGRAM_LIFE": "1"
},
"name": "precompile-play",
"runs": 1,
"step": [
{
"do": "teleport",
"to": "HyruleField_Child"
},
{
"do": "wait",
"map": "HyruleField_Child",
"event": "map",
"timeout_s": 120
},
{
"x": 0.0,
"y": 1.0,
"do": "stick",
"stick": "L",
"frames": 120
},
{
"do": "shot",
"name": "field",
"upload": false,
"compare": "baseline"
},
{
"do": "measure",
"name": "field",
"warmup_s": 5,
"duration_s": 20
},
{
"do": "teleport",
"to": "Market_Child"
},
{
"do": "wait",
"map": "Market_Child",
"event": "map",
"timeout_s": 120
},
{
"x": 0.0,
"y": 1.0,
"do": "stick",
"stick": "L",
"frames": 120
},
{
"do": "shot",
"name": "market",
"upload": false,
"compare": "baseline"
},
{
"do": "measure",
"name": "market",
"warmup_s": 5,
"duration_s": 20
}
],
"start": "save:kokiri-start",
"matrix": true,
"settings": {}
}
]
}
Targets
Reports
| Report | Commit | Target | Tester | Result | When |
|---|---|---|---|---|---|
| rp_6a19b73cd827bdca | a0c457c | windows+ram16gb | TheDevil/agent-690be7 | error | |
| rp_38579eececb5fecc | a0c457c | windows+ram16gb | Hidden tester | error | |
| rp_38aa1b1f84d9d84a | ce69221 | windows+amd | pickaxe/agent-607ffe | fail | |
| rp_b31287ccf80ab4b1 | ce69221 | linux | Alberania/agent-af6cf3 | pass outlier | |
| rp_67371da258c3da95 | ce69221 | windows+amd | Hidden tester | fail | |
| rp_7c22275ad3927e77 | ce69221 | linux | SweatyEggs69/agent-cf0be7 | pass outlier | |
| rp_64c77e86b984dd3c | ce69221 | windows+ram16gb | Hidden tester | error | |
| rp_8545941d9428585c | 098191e | windows | Flashman4/agent-de36c5 | fail | |
| rp_d1fe5593cf6281dc | 098191e | windows | Hidden tester | error | |
| rp_7c605c3993d1f4de | 0995c5f | windows+ram16gb | Hidden tester | error | |
| rp_0ff356f59680d4d5 | c3239a0 | windows | Jiro113/agent-fd7c7b | fail | |
| rp_7dc567082c187eda | c3239a0 | windows | Hidden tester | error |
Jobs
| Job | Commit | Target | State | Tester | Started | Attempts | Estimate | Note |
|---|---|---|---|---|---|---|---|---|
jb_9f14d6f5a0116c54 log | a0c457c | windows+ram16gb | done build-base | TheDevil/agent-690be7 | 12 | build-base: git can't start in the sandbox, so the build can't start (fail git rev-parse HEAD exited 128; fatal: could not open '/dev/null' for reading and writing: Permission denied; readable .git True; readable .git\HEAD True; readable .git\objects True; version). git dies before it reads the checkout: the sandbox refuses it /dev/null (NUL). The app uses its own MinGit for this; if it still happens, tell the farm's team | ||
jb_76fb50d8f7d31ff7 | a0c457c | windows+intel+gpu-arc-* | queued | — | 0 | No tester online can take it now. | No tester online matches `windows+intel+gpu-arc-*`. | |
jb_3b06944a499c1a6e log | a0c457c | windows+ram16gb | done build-base | Hidden tester | 1 | |||
jb_4326b796e17d0161 log | a0c457c | windows+amd | error | — | 7 | report: the farm refused the report: the coordinator answered HTTP 400 (BadRequest): {"error":"report.rules[3].status must be one of pass, fail, unsupported, skipped, mismatch"} | ||
jb_994fd49e3d1aa84d log | a0c457c | windows+amd | error | — | 5 | report: the farm refused the report: the coordinator answered HTTP 400 (BadRequest): {"error":"report.rules[3].status must be one of pass, fail, unsupported, skipped, mismatch"} | ||
jb_3ed8ba48fb2198ef | a0c457c | windows+intel+gpu-arc-* | queued | — | 0 | No tester online can take it now. | No tester online matches `windows+intel+gpu-arc-*`. | |
jb_b1a84b0a132bdc03 log | ce69221 | windows+amd | done run | Hidden tester | 2 | prefetch: less than 30.0 GB free on the work folder's disk | ||
jb_be0b797eecc07418 log | ce69221 | windows+ram16gb | cancelled | — | 1 | superseded by a new push | ||
jb_dd3080d0f9d44970 log | ce69221 | windows+ram16gb | done report | Hidden tester | 1 | |||
jb_fcbbe9ff374f610b log | ce69221 | linux | done report | SweatyEggs69/agent-cf0be7 | 1 | |||
jb_2c670c93366a1eb3 log | ce69221 | linux | done report | Alberania/agent-af6cf3 | 2 | lease expired, tried again: the tester missed its heartbeats | ||
jb_1efb81ab66219d71 log | ce69221 | windows+amd | done run | pickaxe/agent-607ffe | 2 | prefetch: less than 30.0 GB free on the work folder's disk | ||
jb_840ed4e8097f256e log | ce69221 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_4707de232feeae10 log | ce69221 | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_c249b01a99bb63e0 log | 098191e | windows | done build-base | Hidden tester | 1 | |||
jb_356c3d9069dc5135 log | 098191e | windows | done run | Flashman4/agent-de36c5 | 1 | |||
jb_5f44a5631f27f540 log | 0995c5f | windows+ram16gb | done build-base | Hidden tester | 1 | |||
jb_9051a18cc8d1dd32 log | 0995c5f | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_04a6b905d23365b4 log | 0995c5f | windows+intel | cancelled | — | 0 | superseded by a new push | ||
jb_a3ef2a5d562370a0 log | 0995c5f | windows+ram16gb | cancelled | — | 0 | superseded by a new push | ||
jb_82b98f397de81b9d log | c3239a0 | windows | done run | Jiro113/agent-fd7c7b | 1 | |||
jb_14c59009e6b8ff6a log | c3239a0 | windows | done build-base | Hidden tester | 1 |