Beanstalk Longshot test farm
Menu

#1478 perf(host): the game's texture heap is compacted at most once a second, not at every frame (HOS_TEX_COMPACT_MS)

by GummiNaomi closed Open on Forgejo

Commit

Head
54a4271
Base
main 359131b
Run
2
Approval
approved GummiNaomi, ; futondestroyer, · double-reviewed
Sensitive
nx2/oot_patches.py

Plan (gpt-6.1-terra)

Compare Market texture compaction on Linux and Windows AMD, including a Linux lift build.

In plain words

On Linux and Windows AMD, the farm builds both revisions and idles in the child Market for one minute per run, using the PR default and its zero-gap switch. Screenshots and p99 frame times are compared with main; crashes, substantial picture differences, or a p99 regression fail the plan. The farm cannot directly compare the two PR settings’ counts of frames over 16.7 ms or apply the requested setting-specific log checks, so p99 is a proxy. Gameplay takes about 24 minutes per PC, apart from timed lift builds; either hardware target waits if no matching PC is online.

Asked for

linux and windows amd: stand in Castle Town's market for a minute (the debug teleport to Market_Child, no input), once with this PR's default and once with HOS_TEX_COMPACT_MS=0 (the game's own compaction request at every frame, as on main). Expecting: no crash; the same picture on both; with the default no more frames over 16.7 ms than with the switch at 0 (here, on a 9950X3D with an RTX 4070 SUPER on Windows: 1.0 and 1.5 % against 5.4 and 12.6 %); and in the log the line tex: the game's texture heap is compacted at most every 1000 ms with the default and no such line with the switch at 0. A build on Linux is the other thing this asks for: the checklist's Linux build box is still open.

Raw plan 131 lines Download plan.json

  "pass" 
    "crash" false
    "screenshot" 
      "max_diff" 0.05
    
    "frametime_p99_ms" 
      "max_delta_pct" 15
    
  
  "probe" 
    
      "kind" "crash"
    
    
      "kind" "frametime"
    
  
  "matrix" 
    "pr_only" 
      "HOS_TEX_COMPACT_MS" 
        "0"
      
    
  
  "schema" 5
  "target" 
    
      "name" "linux+amd"
      "tags" 
        "linux"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
    
      "name" "windows+amd"
      "tags" 
        "windows"
        "amd"
      
      "max_reports" 2
      "min_reports" 1
    
  
  "timing" 
    "runs" 2
    "caches" 
      "lift"
    
  
  "summary" "Compare Market texture compaction on Linux and Windows AMD, including a Linux lift build."
  "baseline" 
    "ref" "main"
  
  "scenario" 
    
      "env" 
      "name" "market-default"
      "runs" 1
      "step" 
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 5
          "duration_s" 60
        
        
          "do" "shot"
          "name" "market-default"
          "upload" false
          "compare" "baseline"
        
      
      "start" "save:kokiri-start"
      "matrix" false
      "settings" 
        "vsync" 2
        "frame_rate_cap" 6
        "frame_generation" 0
      
    
    
      "env" 
      "name" "market-zero-gap"
      "runs" 1
      "step" 
        
          "do" "teleport"
          "to" "Market_Child"
        
        
          "do" "wait"
          "map" "Market_Child"
          "event" "map"
          "timeout_s" 60
        
        
          "do" "measure"
          "name" "market"
          "warmup_s" 5
          "duration_s" 60
        
        
          "do" "shot"
          "name" "market-zero-gap"
          "upload" false
          "compare" "baseline"
        
      
      "start" "save:kokiri-start"
      "matrix" true
      "settings" 
        "vsync" 2
        "frame_rate_cap" 6
        "frame_generation" 0
      
    
  

Targets

TargetTierReportsStatus
linux+amddouble-reviewed GummiNaomi, futondestroyer none yet 0/1 pass, 0 running, 0 queued
windows+amddouble-reviewed GummiNaomi, futondestroyer none yet 0/1 pass, 0 running, 0 queued

Reports

No reports yet. Each tester posts one when its job ends.

Jobs

JobCommitTargetStateTesterStartedAttemptsEstimateNote
jb_629d29f5b5f12be6 log54a4271linux+amd cancelled build-baseAlberania/agent-af6cf31 the PR was closed
jb_7f2b3a32900ae887 log54a4271windows+amd cancelled build-baseHidden tester1 the PR was closed
jb_56f5f9a4bd7312ba log54a4271windows+amd cancelled build-baseRazytos/agent-d8f9021 the PR was closed
jb_5ebd420617382eba log54a4271linux+amd cancelled—0 the PR was closed